Skip to content

Commit 2fce7ed

Browse files
fix(console): remove deprecated class
1 parent e610dfd commit 2fce7ed

File tree

10 files changed

+140
-552
lines changed

10 files changed

+140
-552
lines changed

gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/main/java/io/gravitee/apim/core/flow/domain_service/FlowValidationDomainService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
import io.gravitee.apim.core.DomainService;
1919
import io.gravitee.apim.core.api.exception.NativeApiWithMultipleFlowsException;
20+
import io.gravitee.apim.core.exception.ValidationDomainException;
2021
import io.gravitee.apim.core.flow.exception.InvalidFlowException;
2122
import io.gravitee.apim.core.plugin.model.PlatformPlugin;
2223
import io.gravitee.apim.core.plugin.query_service.EntrypointPluginQueryService;
@@ -29,7 +30,6 @@
2930
import io.gravitee.definition.model.v4.flow.selector.SelectorType;
3031
import io.gravitee.definition.model.v4.flow.step.Step;
3132
import io.gravitee.definition.model.v4.nativeapi.NativeFlow;
32-
import io.gravitee.rest.api.service.v4.exception.PathParameterOverlapValidationException;
3333
import java.util.ArrayList;
3434
import java.util.Arrays;
3535
import java.util.Collection;
@@ -279,7 +279,7 @@ private void validatePathParamOverlapping(ApiType apiType, Stream<Flow> flows) {
279279
.peek(e -> e.getValue().sort(String::compareTo))
280280
.collect(Collectors.toMap(Map.Entry::getKey, entry -> entry.getValue().toString()));
281281

282-
throw new PathParameterOverlapValidationException(payload);
282+
throw new ValidationDomainException("Invalid path parameters", payload);
283283
}
284284
}
285285

gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/main/java/io/gravitee/rest/api/service/v4/exception/PathParameterOverlapValidationException.java

Lines changed: 0 additions & 59 deletions
This file was deleted.

gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/main/java/io/gravitee/rest/api/service/v4/impl/PlanServiceImpl.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import com.fasterxml.jackson.databind.ObjectMapper;
2727
import io.gravitee.apim.core.audit.model.AuditInfo;
2828
import io.gravitee.apim.core.flow.crud_service.FlowCrudService;
29+
import io.gravitee.apim.core.flow.domain_service.FlowValidationDomainService;
2930
import io.gravitee.apim.core.subscription.domain_service.CloseSubscriptionDomainService;
3031
import io.gravitee.definition.model.v4.ApiType;
3132
import io.gravitee.definition.model.v4.flow.Flow;
@@ -83,7 +84,6 @@
8384
import io.gravitee.rest.api.service.v4.mapper.GenericPlanMapper;
8485
import io.gravitee.rest.api.service.v4.mapper.PlanMapper;
8586
import io.gravitee.rest.api.service.v4.validation.FlowValidationService;
86-
import io.gravitee.rest.api.service.v4.validation.PathParametersValidationService;
8787
import io.gravitee.rest.api.service.v4.validation.TagsValidationService;
8888
import java.util.Arrays;
8989
import java.util.Collection;
@@ -176,7 +176,7 @@ public class PlanServiceImpl extends AbstractService implements PlanService {
176176
private FlowValidationService flowValidationService;
177177

178178
@Autowired
179-
private PathParametersValidationService pathParametersValidationService;
179+
private FlowValidationDomainService flowValidationDomainService;
180180

181181
@Autowired
182182
private GroupService groupService;
@@ -265,7 +265,7 @@ private void validatePathParameters(Api api, List<Flow> newPlanFlows) throws Tec
265265
.flatMap(Collection::stream);
266266
planFlows = Stream.concat(planFlows, newPlanFlows.stream());
267267

268-
pathParametersValidationService.validate(api.getType(), apiFlows, planFlows);
268+
flowValidationDomainService.validatePathParameters(api.getType(), apiFlows, planFlows);
269269
}
270270

271271
private void validateTags(Set<String> tags, Api api) {
@@ -435,7 +435,7 @@ private void validatePathParameters(Api api, UpdatePlanEntity updatePlan) throws
435435
})
436436
.flatMap(Collection::stream);
437437

438-
pathParametersValidationService.validate(api.getType(), apiFlows, planFlows);
438+
flowValidationDomainService.validatePathParameters(api.getType(), apiFlows, planFlows);
439439
}
440440

441441
private void checkStatusOfGeneralConditions(Plan plan) {

gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/main/java/io/gravitee/rest/api/service/v4/impl/validation/ApiValidationServiceImpl.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import static io.gravitee.rest.api.model.api.ApiLifecycleState.UNPUBLISHED;
2222
import static org.apache.commons.lang3.StringUtils.isBlank;
2323

24+
import io.gravitee.apim.core.flow.domain_service.FlowValidationDomainService;
2425
import io.gravitee.definition.model.DefinitionVersion;
2526
import io.gravitee.definition.model.v4.ApiType;
2627
import io.gravitee.definition.model.v4.flow.Flow;
@@ -51,7 +52,6 @@
5152
import io.gravitee.rest.api.service.v4.validation.FlowValidationService;
5253
import io.gravitee.rest.api.service.v4.validation.GroupValidationService;
5354
import io.gravitee.rest.api.service.v4.validation.ListenerValidationService;
54-
import io.gravitee.rest.api.service.v4.validation.PathParametersValidationService;
5555
import io.gravitee.rest.api.service.v4.validation.PlanValidationService;
5656
import io.gravitee.rest.api.service.v4.validation.ResourcesValidationService;
5757
import io.gravitee.rest.api.service.v4.validation.TagsValidationService;
@@ -78,8 +78,8 @@ public class ApiValidationServiceImpl extends TransactionalService implements Ap
7878
private final AnalyticsValidationService analyticsValidationService;
7979
private final PlanSearchService planSearchService;
8080
private final PlanValidationService planValidationService;
81-
private final PathParametersValidationService pathParametersValidationService;
8281
private final ApiServicePluginService apiServicePluginService;
82+
private final FlowValidationDomainService flowValidationDomainService;
8383

8484
public ApiValidationServiceImpl(
8585
final TagsValidationService tagsValidationService,
@@ -91,8 +91,8 @@ public ApiValidationServiceImpl(
9191
final AnalyticsValidationService loggingValidationService,
9292
final PlanSearchService planSearchService,
9393
final PlanValidationService planValidationService,
94-
final PathParametersValidationService pathParametersValidationService,
95-
ApiServicePluginService apiServicePluginService
94+
ApiServicePluginService apiServicePluginService,
95+
FlowValidationDomainService flowValidationDomainService
9696
) {
9797
this.tagsValidationService = tagsValidationService;
9898
this.groupValidationService = groupValidationService;
@@ -103,8 +103,8 @@ public ApiValidationServiceImpl(
103103
this.analyticsValidationService = loggingValidationService;
104104
this.planSearchService = planSearchService;
105105
this.planValidationService = planValidationService;
106-
this.pathParametersValidationService = pathParametersValidationService;
107106
this.apiServicePluginService = apiServicePluginService;
107+
this.flowValidationDomainService = flowValidationDomainService;
108108
}
109109

110110
@Override
@@ -143,7 +143,7 @@ public void validateAndSanitizeNewApi(
143143
// Validate and clean flow
144144
newApiEntity.setFlows(flowValidationService.validateAndSanitize(newApiEntity.getType(), newApiEntity.getFlows()));
145145

146-
pathParametersValidationService.validate(
146+
flowValidationDomainService.validatePathParameters(
147147
newApiEntity.getType(),
148148
(newApiEntity.getFlows() != null ? newApiEntity.getFlows().stream() : Stream.empty()),
149149
Stream.empty()
@@ -204,7 +204,7 @@ public void validateAndSanitizeUpdateApi(
204204
updateApiEntity.setPlans(planValidationService.validateAndSanitize(updateApiEntity.getType(), updateApiEntity.getPlans()));
205205

206206
// Validate path parameters
207-
pathParametersValidationService.validate(
207+
flowValidationDomainService.validatePathParameters(
208208
updateApiEntity.getType(),
209209
(updateApiEntity.getFlows() != null ? updateApiEntity.getFlows().stream() : Stream.empty()),
210210
getPlansFlows(updateApiEntity.getPlans())
@@ -258,7 +258,7 @@ public void validateAndSanitizeImportApiForCreation(
258258
apiEntity.setPlans(planValidationService.validateAndSanitize(apiEntity.getType(), apiEntity.getPlans()));
259259

260260
// Validate path parameters
261-
pathParametersValidationService.validate(
261+
flowValidationDomainService.validatePathParameters(
262262
apiEntity.getType(),
263263
(apiEntity.getFlows() != null ? apiEntity.getFlows().stream() : Stream.empty()),
264264
getPlansFlows(apiEntity.getPlans())

0 commit comments

Comments
 (0)