Fix sonar issues

Signed-off-by: Ayoub LABIDI <[email protected]>

Author: ayolab

src/components/graph/nodes/labeled-group-node.styles.ts

@@ -11,11 +11,18 @@ import { zoomStyles } from '../zoom.styles';
 
 export const LABEL_BLOCK_HEIGHT = 30; // px, matches label box vertical size
 
-export const getContainerStyle = (theme: Theme, isLight: boolean) => ({
-    ...zoomStyles.labeledGroupBorder(theme),
-    background: theme.tree?.is.minimalDetail ? (isLight ? theme.palette.grey[200] : colors.grey[700]) : 'transparent',
-    borderColor: isLight ? colors.grey[400] : colors.grey[500],
-});
+export const getContainerStyle = (theme: Theme, isLight: boolean) => {
+    let backgroundColor = 'transparent';
+    if (theme.tree?.is.minimalDetail) {
+        backgroundColor = isLight ? theme.palette.grey[200] : colors.grey[700];
+    }
+
+    return {
+        ...zoomStyles.labeledGroupBorder(theme),
+        background: backgroundColor,
+        borderColor: isLight ? colors.grey[400] : colors.grey[500],
+    };
+};
 
 export const labeledGroupNodeStyles = {
     label: (theme) => ({

src/components/graph/nodes/network-modification-node.tsx

@@ -49,7 +49,10 @@ const NetworkModificationNode = (props: NodeProps<ModificationNode>) => {
     }, [props.id, selectionForCopy]);
 
     const nodeOpacity = useMemo(() => {
-        return isSelectedForCut() ? (getLocalStorageTheme() === LIGHT_THEME ? 0.3 : 0.6) : 1;
+        if (!isSelectedForCut()) {
+            return 1;
+        }
+        return getLocalStorageTheme() === LIGHT_THEME ? 0.3 : 0.6;
     }, [isSelectedForCut]);
 
     const tooltipContent = useMemo(() => {