fix warnings

Author: AgraVator

xds/src/main/java/io/grpc/xds/CompositeFilter.java

@@ -48,6 +48,8 @@
 import java.util.List;
 import java.util.concurrent.ScheduledExecutorService;
 import java.util.concurrent.ThreadLocalRandom;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 import javax.annotation.Nullable;
 import javax.net.ssl.SNIHostName;
 import javax.net.ssl.SNIServerName;
@@ -74,6 +76,7 @@ public final class CompositeFilter implements Filter {
       "type.googleapis.com/envoy.extensions.matching.common_inputs.network.v3.ServerNameInput";
 
   private static final CompositeFilter INSTANCE = new CompositeFilter();
+  private static final Logger log = Logger.getLogger(CompositeFilter.class.getName());
 
   private CompositeFilter() {
   }
@@ -424,7 +427,7 @@ public String getRelayedInput(com.github.xds.core.v3.TypedExtensionConfig inputC
           String headerName = input.getHeaderName();
           return headers.get(Metadata.Key.of(headerName, Metadata.ASCII_STRING_MARSHALLER));
         } catch (InvalidProtocolBufferException e) {
-          // log/ignore
+          log.log(Level.WARNING, "Unable to get headers from the request for matching", e);
         }
       } else if (TYPE_URL_SOURCE_IP_INPUT.equals(typeUrl)) {
         SocketAddress addr = attributes.get(Grpc.TRANSPORT_ATTR_REMOTE_ADDR);

xds/src/main/java/io/grpc/xds/XdsNameResolver.java

@@ -336,7 +336,6 @@ private void updateResolutionResult(XdsConfig xdsConfig) {
             .setAttributes(attrs)
             .setServiceConfig(parsedServiceConfig)
             .build();
-    // todo: abhishek probably the filters are getting applied here ??
     if (!listener.onResult2(result).isOk()) {
       resolveState.xdsDependencyManager.requestReresolution();
     }
@@ -405,7 +404,6 @@ static boolean matchHostName(String hostName, String pattern) {
   private final class ConfigSelector extends InternalConfigSelector {
     @Override
     public Result selectConfig(PickSubchannelArgs args) {
-      // todo: AgraVator probably the filters are getting populated here
       RoutingConfig routingCfg;
       RouteData selectedRoute;
       String cluster;

xds/src/test/java/io/grpc/xds/CompositeFilterTest.java

@@ -48,6 +48,7 @@
 import org.mockito.MockitoAnnotations;
 
 @RunWith(JUnit4.class)
+@SuppressWarnings({ "rawtypes", "unchecked" })
 public class CompositeFilterTest {
 
   private final CompositeFilter.Provider provider = new CompositeFilter.Provider();
@@ -157,7 +158,6 @@ public void parseConfig() {
   }
 
   @Test
-  @SuppressWarnings("unchecked")
   public void clientInterceptorDelegates() {
     // Setup Config with simple matcher equivalent logic
     Matcher.OnMatch matchAction = Matcher.OnMatch.newBuilder()
@@ -255,9 +255,8 @@ public void clientInterceptorDelegates() {
   }
 
   @Test
-  @SuppressWarnings("unchecked")
   public void clientInterceptorSkips() {
-    // Same setup but no match
+    // Setup Config with simple matcher equivalent logic with no match
     Matcher matcher = Matcher.newBuilder().build();
 
     ExtensionWithMatcher proto = ExtensionWithMatcher.newBuilder()
@@ -289,12 +288,12 @@ public void clientInterceptorSkips() {
     Metadata headers = new Metadata();
     call.start(mock(ClientCall.Listener.class), headers);
 
+    verify(fakeClientInterceptor, org.mockito.Mockito.never()).interceptCall(any(), any(), any());
     verify(next).newCall(any(), any());
     verify(nextCall).start(any(), eq(headers));
   }
 
   @Test
-  @SuppressWarnings("unchecked")
   public void clientInterceptorDelegatesChain() {
     // Setup Chain Action
     TypedExtensionConfig child1 = TypedExtensionConfig.newBuilder()
@@ -393,7 +392,6 @@ public void clientInterceptorDelegatesChain() {
     fakeClientInterceptor = mock(ClientInterceptor.class);
     when(fakeFilter.buildClientInterceptor(any(), any(), any())).thenReturn(fakeClientInterceptor);
 
-    ClientCall childCall = mock(ClientCall.class);
     org.mockito.Mockito.doAnswer(invocation -> {
       io.grpc.Channel nextArg = (io.grpc.Channel) invocation.getArguments()[2];
       return nextArg.newCall(