Try to switch to setting regions via vars

Author: brikis98

examples/couchbase-multi-datacenter-replication/main.tf

@@ -12,6 +12,16 @@ terraform {
   required_version = ">= 0.12"
 }
 
+provider "aws" {
+  alias  = "primary"
+  region = var.primary_region
+}
+
+provider "aws" {
+  alias  = "replica"
+  region = var.replica_region
+}
+
 # ---------------------------------------------------------------------------------------------------------------------
 # DEPLOY THE PRIMARY COUCHBASE CLUSTER
 # ---------------------------------------------------------------------------------------------------------------------

examples/couchbase-multi-datacenter-replication/providers.tf

@@ -11,6 +11,16 @@
 # You must provide a value for each of these parameters.
 # ---------------------------------------------------------------------------------------------------------------------
 
+variable "primary_region" {
+  description = "The region to deploy the primary to"
+  type        = string
+}
+
+variable "replica_region" {
+  description = "The region to deploy the replica to"
+  type        = string
+}
+
 # ---------------------------------------------------------------------------------------------------------------------
 # OPTIONAL PARAMETERS
 # These parameters have reasonable defaults.

examples/couchbase-multi-datacenter-replication/variables.tf

@@ -1,17 +1,14 @@
 package test
 
 import (
-	"testing"
-	"path/filepath"
 	"fmt"
-	"sync"
-	"github.com/gruntwork-io/terratest/modules/test-structure"
+	"github.com/gruntwork-io/terratest/modules/aws"
 	"github.com/gruntwork-io/terratest/modules/random"
 	"github.com/gruntwork-io/terratest/modules/terraform"
-	"github.com/gruntwork-io/terratest/modules/aws"
-	"github.com/gruntwork-io/terratest/modules/files"
-	"os"
-	"github.com/gruntwork-io/terratest/modules/logger"
+	"github.com/gruntwork-io/terratest/modules/test-structure"
+	"path/filepath"
+	"sync"
+	"testing"
 )
 
 const clusterNamePrimaryVarName = "cluster_name_primary"
@@ -105,8 +102,6 @@ func testCouchbaseMultiDataCenterReplication(t *testing.T, osName string, editio
 		terraformOptions := test_structure.LoadTerraformOptions(t, couchbaseMultiClusterDir)
 		terraform.Destroy(t, terraformOptions)
 
-		restoreProvider(t, couchbaseMultiClusterDir)
-
 		amiIdPrimary := test_structure.LoadString(t, couchbaseMultiClusterDir, savedAmiIdPrimary)
 		amiIdReplica := test_structure.LoadString(t, couchbaseMultiClusterDir, savedAmiIdReplica)
 
@@ -136,15 +131,15 @@ func testCouchbaseMultiDataCenterReplication(t *testing.T, osName string, editio
 		uniqueIdPrimary := test_structure.LoadString(t, couchbaseMultiClusterDir, savedUniqueIdPrimary)
 		uniqueIdReplica := test_structure.LoadString(t, couchbaseMultiClusterDir, savedUniqueIdReplica)
 
-		overrideProvider(t, couchbaseMultiClusterDir, awsRegionPrimary, awsRegionReplica)
-
 		terraformOptions := &terraform.Options{
 			TerraformDir: couchbaseMultiClusterDir,
-			Vars: map[string]interface{} {
-				"ami_id_primary":           amiIdPrimary,
-				"ami_id_replica":           amiIdReplica,
-				clusterNamePrimaryVarName:  formatCouchbaseClusterName("primary", uniqueIdPrimary),
-				clusterNameReplicaVarName:	formatCouchbaseClusterName("replica", uniqueIdReplica),
+			Vars: map[string]interface{}{
+				"primary_region":          awsRegionPrimary,
+				"replica_region":          awsRegionReplica,
+				"ami_id_primary":          amiIdPrimary,
+				"ami_id_replica":          amiIdReplica,
+				clusterNamePrimaryVarName: formatCouchbaseClusterName("primary", uniqueIdPrimary),
+				clusterNameReplicaVarName: formatCouchbaseClusterName("replica", uniqueIdReplica),
 			},
 		}
 
@@ -168,55 +163,3 @@ func testCouchbaseMultiDataCenterReplication(t *testing.T, osName string, editio
 		checkReplicationIsWorking(t, consoleUrlPrimary, consoleUrlReplica, "test-bucket", "test-bucket-replica")
 	})
 }
-
-const providerOverrideTemplate = `
-# This file temporarily overrides the providers at test time. The original providers file should be restored at the
-# end of the test!
-
-provider "aws" {
-  alias  = "primary"
-  region = "%s"
-}
-
-provider "aws" {
-  alias  = "replica"
-  region = "%s"
-}
-`
-
-// In order for the examples to work well with the Terraform Registry, where they are wrapped in a module, we cannot
-// define the AWS regions in those providers. This works OK for manual usage, where the user can specify the region
-// interactively, but not at test time. Therefore, as a workaround, we override the providers.tf file at test time
-// with the regions fully defined, and then put it back at the end of the test in the restoreProvider function.
-func overrideProvider(t *testing.T, couchbaseMultiClusterDir string, awsRegionPrimary string, awsRegionReplica string) {
-	providersFilePath := filepath.Join(couchbaseMultiClusterDir, providersFile)
-	providersFileBackupPath := filepath.Join(couchbaseMultiClusterDir, providersFileBackup)
-
-	logger.Logf(t, "Backing up %s to %s", providersFilePath, providersFileBackupPath)
-	if err := files.CopyFile(providersFilePath, providersFileBackupPath); err != nil {
-		t.Fatal(err)
-	}
-
-	newProvidersFileContents := fmt.Sprintf(providerOverrideTemplate, awsRegionPrimary, awsRegionReplica)
-
-	logger.Logf(t, "Creating override proviers file at %s with contents:\n%s", providersFilePath, newProvidersFileContents)
-	if err := files.WriteFileWithSamePermissions(providersFilePath, providersFilePath, []byte(newProvidersFileContents)); err != nil {
-		t.Fatal(err)
-	}
-}
-
-// See the overrideProvider method for details
-func restoreProvider(t *testing.T, couchbaseMultiClusterDir string) {
-	providersFilePath := filepath.Join(couchbaseMultiClusterDir, providersFile)
-	providersFileBackupPath := filepath.Join(couchbaseMultiClusterDir, providersFileBackup)
-
-	logger.Logf(t, "Restoring %s from %s", providersFilePath, providersFileBackupPath)
-	if err := files.CopyFile(providersFileBackupPath, providersFilePath); err != nil {
-		t.Fatal(err)
-	}
-
-	logger.Logf(t, "Deleting %s", providersFileBackupPath)
-	if err := os.Remove(providersFileBackupPath); err != nil {
-		t.Fatal(err)
-	}
-}