Refactor Tor/VPN actions to use ViewModel events #1426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been testing this for a few weeks without any issues. |
|
I just noticed that when these changes are applied, then I have to select the stop button twice before tor will disconnect. |
meenbeese
force-pushed
the
viewmodel-new
branch
from
666148d to
88d5367
Compare
Tapping on the stop button does take a bit of time, but I can get it to work without tapping twice. |
meenbeese
force-pushed
the
viewmodel-new
branch
from
88d5367 to
fc5a354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces direct method calls for starting/stopping Tor and VPN, refreshing menu, and sending Newnym signal with event-based triggers in
ConnectViewModel. This improves separation of concerns and centralizes UI event handling, making the codebase more maintainable and testable.Tested on Pixel 8 API 35.