Skip to content

Commit 00fc9aa

Browse files
committed
Uncomment execution reverted error in errors.go and update related comments
1 parent b074b99 commit 00fc9aa

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

core/vm/errors.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,15 @@ var (
3131
ErrDepth = errors.New("max call depth exceeded")
3232
ErrInsufficientBalance = errors.New("insufficient balance for transfer")
3333
ErrContractAddressCollision = errors.New("contract address collision")
34-
ErrExecutionReverted = errors.New("execution reverted")
35-
ErrMaxCodeSizeExceeded = errors.New("max code size exceeded")
36-
ErrInvalidJump = errors.New("invalid jump destination")
37-
ErrWriteProtection = errors.New("write protection")
38-
ErrReturnDataOutOfBounds = errors.New("return data out of bounds")
39-
ErrGasUintOverflow = errors.New("gas uint64 overflow")
40-
ErrInvalidRetsub = errors.New("invalid retsub")
41-
ErrReturnStackExceeded = errors.New("return stack limit reached")
42-
ErrNoCompatibleInterpreter = errors.New("no compatible interpreter")
34+
//ErrExecutionReverted = errors.New("execution reverted") // TODO should be uncommented in future version
35+
ErrMaxCodeSizeExceeded = errors.New("max code size exceeded")
36+
ErrInvalidJump = errors.New("invalid jump destination")
37+
ErrWriteProtection = errors.New("write protection")
38+
ErrReturnDataOutOfBounds = errors.New("return data out of bounds")
39+
ErrGasUintOverflow = errors.New("gas uint64 overflow")
40+
ErrInvalidRetsub = errors.New("invalid retsub")
41+
ErrReturnStackExceeded = errors.New("return stack limit reached")
42+
ErrNoCompatibleInterpreter = errors.New("no compatible interpreter")
4343
)
4444

4545
// ErrStackUnderflow wraps an evm error when the items on the stack less

core/vm/instructions.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ var (
3434
tt255 = math.BigPow(2, 255)
3535
errWriteProtection = errors.New("evm: write protection")
3636
errReturnDataOutOfBounds = errors.New("evm: return data out of bounds")
37-
//ErrExecutionReverted = errors.New("evm: execution reverted")
38-
errMaxCodeSizeExceeded = errors.New("evm: max code size exceeded")
39-
errInvalidJump = errors.New("evm: invalid jump destination")
37+
ErrExecutionReverted = errors.New("evm: execution reverted") // TODO: should be commented in future versions
38+
errMaxCodeSizeExceeded = errors.New("evm: max code size exceeded")
39+
errInvalidJump = errors.New("evm: invalid jump destination")
4040
)
4141

4242
func opAdd(pc *uint64, interpreter *EVMInterpreter, callContext *callCtx) ([]byte, error) {

0 commit comments

Comments
 (0)