Skip to content

Conversation

@meirish
Copy link
Collaborator

@meirish meirish commented Jul 30, 2025

Description

There were still a good number of component templates left in the templates/components directory. Ember has long supported (2019!) colocation of components and their templates. Handily, there is also a codemod that will do this change for you. There was one hiccup in that the codemod is old enough, it doesn't recognize some newer syntax, but there is also a PR to fix this issue.

This PR is the result of running this command in the ui directory:

npx github:apellerano-pw/ember-component-template-colocation-migrator#major-bump-ember-template-recast-v3-to-v6

JIRA ticket

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@meirish meirish requested a review from a team as a code owner July 30, 2025 22:12
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 30, 2025
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

@meirish meirish changed the title run colocated components codemod [UI] - run colocated components codemod Aug 1, 2025
@meirish meirish added this to the 1.20.2 milestone Aug 1, 2025
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@zofskeez zofskeez merged commit 4a2b5bf into main Aug 1, 2025
52 of 56 checks passed
@zofskeez zofskeez deleted the colocated-components branch August 1, 2025 16:04
meirish added a commit that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants