Skip to content

Commit 25272e3

Browse files
Communication submodule (#9170)
Signed-off-by: Kristina Fefelova <[email protected]>
1 parent 38e1851 commit 25272e3

File tree

24 files changed

+414
-384
lines changed

24 files changed

+414
-384
lines changed

.github/workflows/main.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ on:
2222

2323
env:
2424
CacheFolders: |
25+
communication
2526
common
2627
desktop
2728
desktop-package
@@ -56,6 +57,7 @@ jobs:
5657
with:
5758
fetch-depth: 0
5859
filter: tree:0
60+
submodules: recursive
5961
- uses: actions/setup-node@v4
6062
with:
6163
node-version-file: '.nvmrc'
@@ -112,6 +114,7 @@ jobs:
112114
with:
113115
fetch-depth: 0
114116
filter: tree:0
117+
submodules: recursive
115118

116119
- uses: actions/setup-node@v4
117120
with:
@@ -136,6 +139,7 @@ jobs:
136139
- uses: actions/checkout@v4
137140
with:
138141
fetch-depth: 0
142+
submodules: recursive
139143
- uses: actions/setup-node@v4
140144
with:
141145
node-version-file: '.nvmrc'
@@ -178,6 +182,7 @@ jobs:
178182
with:
179183
fetch-depth: 0
180184
filter: tree:0
185+
submodules: recursive
181186
- uses: actions/setup-node@v4
182187
with:
183188
node-version-file: '.nvmrc'
@@ -214,6 +219,7 @@ jobs:
214219
with:
215220
fetch-depth: 0
216221
filter: tree:0
222+
submodules: recursive
217223
- uses: actions/setup-node@v4
218224
with:
219225
node-version-file: '.nvmrc'
@@ -343,6 +349,7 @@ jobs:
343349
with:
344350
fetch-depth: 0
345351
filter: tree:0
352+
submodules: recursive
346353
- uses: actions/setup-node@v4
347354
with:
348355
node-version-file: '.nvmrc'
@@ -437,6 +444,7 @@ jobs:
437444
with:
438445
fetch-depth: 0
439446
filter: tree:0
447+
submodules: recursive
440448
- uses: actions/setup-node@v4
441449
with:
442450
node-version-file: '.nvmrc'
@@ -514,6 +522,7 @@ jobs:
514522
with:
515523
fetch-depth: 0
516524
filter: tree:0
525+
submodules: recursive
517526
- uses: actions/setup-node@v4
518527
with:
519528
node-version-file: '.nvmrc'
@@ -617,6 +626,7 @@ jobs:
617626
with:
618627
fetch-depth: 0
619628
filter: tree:0
629+
submodules: recursive
620630

621631
- name: Checkout init repository
622632
run: |

.gitmodules

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
[submodule "communication"]
2+
path = communication
3+
url = https://github.com/hcengineering/communication.git

README.md

Lines changed: 25 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ You can find API usage examples in the [Huly examples](https://github.com/hcengi
3838
- [Table of Contents](#table-of-contents)
3939
- [Pre-requisites](#pre-requisites)
4040
- [Verification](#verification)
41-
- [Fast start](#fast-start)
4241
- [Branches \& Contributing](#branches--contributing)
43-
- [Authentication](#authentication)
42+
- [Setup dev environment](#setup-dev-environment)
43+
- [Fast start](#fast-start)
4444
- [Installation](#installation)
4545
- [Build and run](#build-and-run)
4646
- [Run in development mode](#run-in-development-mode)
@@ -71,12 +71,6 @@ docker --version
7171
docker compose version
7272
```
7373

74-
## Fast start
75-
76-
```bash
77-
sh ./scripts/fast-start.sh
78-
```
79-
8074
## Branches & Contributing
8175

8276
- The `main` branch is the default branch used for production deployments.
@@ -89,7 +83,22 @@ sh ./scripts/fast-start.sh
8983

9084
We periodically merge `develop` into `staging` to perform testing builds. Once we are satisfied with the build quality in our pre-release deployment, we merge changes into `main` and release a new version to the community.
9185

92-
## Authentication
86+
## Setup dev environment
87+
88+
### To initialise the communication submodule
89+
90+
```bash
91+
git submodule init
92+
git submodule update
93+
```
94+
95+
### To update the communication submodule
96+
97+
```bash
98+
git submodule update
99+
```
100+
101+
### Authentication
93102

94103
This project uses GitHub Packages for dependency management. To successfully download dependencies, you need to generate a GitHub personal access token and log in to npm using that token.
95104

@@ -109,6 +118,13 @@ npm login --registry=https://npm.pkg.github.com
109118

110119
When prompted, enter your GitHub username, use the generated token as your password
111120

121+
122+
## Fast start
123+
124+
```bash
125+
sh ./scripts/fast-start.sh
126+
```
127+
112128
## Installation
113129

114130
You need Microsoft's [rush](https://rushjs.io) to install the application.

common/config/rush/pnpm-lock.yaml

Lines changed: 292 additions & 340 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

communication

Submodule communication added at 543baed

packages/presentation/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@
4444
"@hcengineering/client": "^0.6.18",
4545
"@hcengineering/contact": "^0.6.24",
4646
"@hcengineering/collaborator-client": "^0.6.4",
47-
"@hcengineering/communication-client-query": "0.1.195",
48-
"@hcengineering/communication-sdk-types": "0.1.195",
49-
"@hcengineering/communication-types": "0.1.195",
47+
"@hcengineering/communication-client-query": "^0.1.0",
48+
"@hcengineering/communication-sdk-types": "^0.1.0",
49+
"@hcengineering/communication-types": "^0.1.0",
5050
"@hcengineering/core": "^0.6.32",
5151
"@hcengineering/diffview": "^0.6.0",
5252
"@hcengineering/notification": "^0.6.23",

plugins/activity-resources/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
"@hcengineering/ui": "^0.6.15",
5151
"@hcengineering/view": "^0.6.13",
5252
"@hcengineering/view-resources": "^0.6.0",
53-
"@hcengineering/communication-types": "0.1.195",
53+
"@hcengineering/communication-types": "^0.1.0",
5454
"@hcengineering/emoji": "^0.6.0",
5555
"@hcengineering/emoji-resources": "^0.6.0",
5656
"svelte": "^4.2.19"

plugins/card-resources/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"dependencies": {
4242
"@hcengineering/presence": "^0.6.0",
4343
"@hcengineering/presentation": "^0.6.3",
44-
"@hcengineering/communication-types": "0.1.195",
44+
"@hcengineering/communication-types": "^0.1.0",
4545
"@hcengineering/communication-resources": "^0.6.0",
4646
"@hcengineering/core": "^0.6.32",
4747
"@hcengineering/ui": "^0.6.15",

plugins/card-resources/src/components/LabelsPresenter.svelte

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import { Label } from '@hcengineering/communication-types'
2020
import tag, { type TagElement } from '@hcengineering/tags'
2121
import { TagElementPresenter } from '@hcengineering/tags-resources'
22+
import { Ref } from '@hcengineering/core'
2223
2324
export let value: Card | undefined = undefined
2425
@@ -33,9 +34,11 @@
3334
labels = res
3435
})
3536
36-
$: client.findAll(tag.class.TagElement, { _id: { $in: labels.map((it) => it.label) } }).then((res) => {
37-
tags = res
38-
})
37+
$: client
38+
.findAll(tag.class.TagElement, { _id: { $in: labels.map((it) => it.label) as any as Ref<TagElement>[] } })
39+
.then((res) => {
40+
tags = res
41+
})
3942
</script>
4043

4144
{#if tags.length > 0}

plugins/chat-resources/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
"@hcengineering/card": "^0.6.0",
4343
"@hcengineering/card-resources": "^0.6.0",
4444
"@hcengineering/chat": "^0.6.0",
45-
"@hcengineering/communication-types": "0.1.195",
45+
"@hcengineering/communication-types": "^0.1.0",
4646
"@hcengineering/contact": "^0.6.24",
4747
"@hcengineering/contact-resources": "^0.6.0",
4848
"@hcengineering/core": "^0.6.32",

0 commit comments

Comments
 (0)