Skip to content

Commit 7c5de8b

Browse files
Fix "Test is missing assertions" warnings
`test_set_null_fields_on_migrations` ./devise/test/models_test.rb:87 `test_does_not_crash_when_the_last_request_at_is_a_String` ./devise/test/integration/timeoutable_test.rb:191 `test_defined_Warden_after_authentication_callback_should_not_be_called_when_sign_in_is_called` ./devise/test/test/controller_helpers_test.rb:114 `test_defined_Warden_before_logout_callback_should_not_be_called_when_sign_out_is_called` ./devise/test/test/controller_helpers_test.rb:128
1 parent 731074b commit 7c5de8b

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

test/integration/timeoutable_test.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,9 @@ def last_request_at
191191
test 'does not crash when the last_request_at is a String' do
192192
user = sign_in_as_user
193193

194-
get edit_form_user_path(user, last_request_at: Time.now.utc.to_s)
195-
get users_path
194+
assert_nothing_raised do
195+
get edit_form_user_path(user, last_request_at: Time.now.utc.to_s)
196+
get users_path
197+
end
196198
end
197199
end

test/models_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def assert_include_modules(klass, *modules)
9090
def send_devise_notification(*); end
9191
end
9292

93-
klass.create!
93+
assert_nothing_raised { klass.create! }
9494
end
9595
end
9696

test/test/controller_helpers_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ def respond
112112
end
113113

114114
test "defined Warden after_authentication callback should not be called when sign_in is called" do
115-
begin
115+
assert_nothing_raised do
116116
Warden::Manager.after_authentication do |user, auth, opts|
117117
flunk "callback was called while it should not"
118118
end
@@ -126,7 +126,7 @@ def respond
126126
end
127127

128128
test "defined Warden before_logout callback should not be called when sign_out is called" do
129-
begin
129+
assert_nothing_raised do
130130
Warden::Manager.before_logout do |user, auth, opts|
131131
flunk "callback was called while it should not"
132132
end

0 commit comments

Comments
 (0)