feat: If componentn is empty, html is returned empty

Author: ahmetkuslular

package.json

@@ -1,6 +1,6 @@
 {
   "name": "voltranjs",
-  "version": "1.2.0-beta.7",
+  "version": "1.2.0-beta.8",
   "main": "src/index.js",
   "author": "Hepsiburada Technology Team",
   "bin": {

src/renderMultiple.js

@@ -124,7 +124,6 @@ async function setInitialStates(renderers) {
         const winner = getWinner(requests, hashes);
         incWinnerScore(winner, hashes);
         putWinnerMap(serviceName, renderer.winnerMap, winner);
-
         if (!promises[winner.hash]) {
           promises[winner.hash] = callback => {
             winner

src/universal/components/App.js

@@ -47,9 +47,7 @@ class App extends PureComponent {
     const { isHydratingCompleted } = this.state;
     return (
       <ReactRenderContext.Provider value={isHydratingCompleted}>
-        <div>
-          <Switch>{renderRoutes(this.generateRoutingProps())}</Switch>
-        </div>
+        <Switch>{renderRoutes(this.generateRoutingProps())}</Switch>
       </ReactRenderContext.Provider>
     );
   }

src/universal/components/Html.js

@@ -31,16 +31,17 @@ function Html({
   isMobileFragment,
   context
 }) {
-  return `
+  if (children) {
+    return `
     <div>
       ${styleTags}
       <script type='text/javascript'>${generateInitialState(initialState, componentName)}</script>
       <div
         id='${componentName.replace(/['"']+/g, '')}_${initialState.id}'
         style="pointer-events: none;"
         class="${voltranConfig.prefix}-voltran-body voltran-body ${
-    isMobileFragment ? 'mobile' : ''
-  }${fullWidth ? 'full' : ''} ${componentClassName(componentName, context)}">
+      isMobileFragment ? 'mobile' : ''
+    }${fullWidth ? 'full' : ''} ${componentClassName(componentName, context)}">
         ${children}
       </div>
       <div>REPLACE_WITH_LINKS</div>
@@ -55,6 +56,9 @@ function Html({
         `<meta name="viewport" content="width=device-width, initial-scale=1, user-scalable=0" />`
       )}
     </div>`;
+  }
+
+  return '';
 }
 
 export default Html;

src/universal/components/RequestDispatcher/RequestDispatcher.js

@@ -1,4 +1,4 @@
-import { useEffect } from 'react';
+ import { useEffect } from 'react';
 
 import withBaseComponent from '../../partials/withBaseComponent';
 import { getEventBus } from '../../utils/helper';