Skip to content

Commit e99ee55

Browse files
committed
Minor updates
1 parent c8b5ced commit e99ee55

File tree

14 files changed

+107
-53
lines changed

14 files changed

+107
-53
lines changed

config/string.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ function replaceString() {
3939
flags: 'g'
4040
},
4141
{
42-
search: '__V_PREVIEW_PAGES__',
42+
search: '__V_PREVIEW__',
4343
replace: normalizeUrl(
44-
voltranConfig.routing.previewPages || path.resolve(__dirname, './emptyModule.js')
44+
voltranConfig.routing.preview || path.resolve(__dirname, './emptyModule.js')
4545
),
4646
flags: 'g'
4747
},

src/render.js

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import xss from 'xss';
22

33
import { matchUrlInRouteConfigs } from './universal/core/route/routeUtils';
4-
import Preview from './universal/components/Preview';
54
import { BLACKLIST_OUTPUT, HTTP_STATUS_CODES } from './universal/utils/constants';
65
import metrics from './metrics';
76
import {
@@ -14,20 +13,9 @@ import {
1413
import Component from './universal/model/Component';
1514
import logger from './universal/utils/logger';
1615
import omit from 'lodash/omit';
16+
import { getPreviewFile } from './universal/utils/previewHelper';
1717

1818
const appConfig = require('__APP_CONFIG__');
19-
const previewPages = require('__V_PREVIEW_PAGES__');
20-
21-
function getPreview(output) {
22-
const { layouts = {} } = previewPages?.default || {};
23-
let PreviewFile = Preview;
24-
25-
if (layouts.default) {
26-
PreviewFile = layouts.default;
27-
}
28-
29-
return PreviewFile(output);
30-
}
3119

3220
const render = async (req, res) => {
3321
const isWithoutStateValue = isWithoutState(req.query);
@@ -102,8 +90,10 @@ const render = async (req, res) => {
10290
context
10391
);
10492
const requestDispatcherFullHtml = requestDispatcherResponse.fullHtml;
93+
const PreviewFile = getPreviewFile(context.query);
94+
const body = [requestDispatcherFullHtml, fullHtml].join('\n');
10595

106-
const response = getPreview([requestDispatcherFullHtml, fullHtml].join('\n'));
96+
const response = PreviewFile({ body, componentName });
10797

10898
res.status(statusCode).html(response);
10999
} else {

src/renderMultiple.js

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,16 @@ import async from 'async';
33
import { matchUrlInRouteConfigs } from './universal/core/route/routeUtils';
44
import Component from './universal/model/Component';
55
import Renderer from './universal/model/Renderer';
6-
import Preview from './universal/components/Preview';
76
import {
87
isRequestDispatcher,
98
isPreview,
109
isWithoutHTML,
11-
isWithoutState,
12-
getPreviewLayout
10+
isWithoutState
1311
} from './universal/service/RenderService';
1412
import metrics from './metrics';
1513
import { HTTP_STATUS_CODES } from './universal/utils/constants';
1614
import logger from './universal/utils/logger';
17-
18-
const previewPages = require('__V_PREVIEW_PAGES__');
15+
import { getPreviewFile } from './universal/utils/previewHelper';
1916

2017
const getRenderOptions = req => {
2118
const isPreviewValue = isPreview(req.query) || false;
@@ -192,21 +189,20 @@ async function getResponses(renderers) {
192189
}
193190

194191
async function getPreview(responses, requestCount, req) {
195-
const layoutName = getPreviewLayout(req.query);
196-
const { layouts = {} } = previewPages?.default || {};
197192
const componentNames = Object.keys(responses);
198-
let PreviewFile = Preview;
199-
200-
if (layouts[layoutName]) {
201-
PreviewFile = layouts[layoutName];
202-
}
193+
const PreviewFile = getPreviewFile(req.query);
203194

204195
const content = Object.keys(responses).map(name => {
205196
const componentName = responses?.[name]?.activeComponent?.componentName ?? '';
206197
return getLayoutWithClass(componentName, responses[name].fullHtml);
207198
});
199+
const body = [...content].join('\n');
208200

209-
return PreviewFile([...content].join('\n'), `${requestCount} request!`, componentNames);
201+
return PreviewFile({
202+
body,
203+
requestCount,
204+
componentNames
205+
});
210206
}
211207

212208
const DEFAULT_PARTIALS = ['RequestDispatcher'];

src/universal/components/Preview.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
const appConfig = require('__APP_CONFIG__');
22

3-
export default (body, title = null) => {
4-
const additionalTitle = title ? ` - ${title}` : '';
3+
export default ({ body, componentName = '' }) => {
4+
const additionalTitle = componentName ? ` - ${componentName}` : '';
55

66
function cr(condition, ok, cancel) {
77
return condition ? ok : cancel || '';

src/universal/core/apiService/apiManager/BaseApiManager.js

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
import axios from 'axios';
2+
import Cookies from 'js-cookie';
23
import {
34
CONTENT_TYPE_HEADER,
45
JSON_CONTENT_TYPE,
56
REQUEST_TYPES_WITH_BODY
67
} from '../../../utils/constants';
8+
import voltranConfig from '../../../../../voltran.config';
9+
import CookieService from '../../../service/CookieService';
710

811
function createBaseConfig() {
912
return {};
@@ -22,6 +25,22 @@ class BaseApiManager {
2225
headers['Accept-Encoding'] = 'gzip, deflate';
2326
}
2427

28+
if (process.env.BROWSER && voltranConfig.setCookiesToHeader) {
29+
const cookieMap = CookieService.getAllItems();
30+
31+
Object.keys(cookieMap).forEach(key => {
32+
if (voltranConfig.setCookiesToHeaderKeys.length > 0) {
33+
voltranConfig.setCookiesToHeaderKeys.map(item => {
34+
if (key.indexOf(item) === 0) {
35+
headers[key] = cookieMap[key];
36+
}
37+
});
38+
} else {
39+
headers[key] = cookieMap[key];
40+
}
41+
});
42+
}
43+
2544
this.api = this.createInstance({
2645
...createBaseConfig(),
2746
...customConfig,

src/universal/core/apiService/apiManager/ClientApiManager.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,16 @@
11
import createApiClient from '../utils/createApiClient';
22
import BaseApiManager from './BaseApiManager';
33

4-
export default (config, timeout) => {
4+
export default (entity, serviceConfigs) => {
5+
const baseURL = entity.clientUrl || entity.url || entity.serverUrl || '/';
6+
const config = {
7+
...serviceConfigs,
8+
...entity?.config
9+
};
10+
511
const apiManager = new BaseApiManager({
6-
baseURL: config.clientUrl || config.url || config.serverUrl || '/',
7-
timeout
12+
baseURL,
13+
...config
814
});
915

1016
return createApiClient(apiManager);

src/universal/core/apiService/apiManager/ServerApiManager.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ const BASE_HTTP_AGENT_CONFIG = {
99
rejectUnauthorized: false
1010
};
1111

12-
export default (config, timeout) => {
12+
export default (entity, serviceConfigs) => {
1313
const apiManager = new BaseApiManager({
14-
timeout,
15-
baseURL: config.serverUrl || config.url || config.clientUrl || '/',
14+
baseURL: entity.serverUrl || entity.url || entity.clientUrl || '/',
15+
...serviceConfigs,
1616
httpAgent: new http.Agent(BASE_HTTP_AGENT_CONFIG),
1717
httpsAgent: new https.Agent(BASE_HTTP_AGENT_CONFIG)
1818
});

src/universal/core/apiService/apiManagerCache/ClientApiManagerCache.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
import ClientApiManager from '../apiManager/ClientApiManager';
33
import createCache from '../utils/createCache';
44

5-
const { services, timeouts } = require('__APP_CONFIG__');
5+
const { services, serviceConfigs } = require('__APP_CONFIG__');
66

7-
const cache = createCache(ClientApiManager, services, timeouts.clientApiManager);
7+
const cache = createCache(ClientApiManager, services, serviceConfigs?.client);
88

99
export default cache;

src/universal/core/apiService/apiManagerCache/ServerApiManagerCache.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
import ServerApiManager from '../apiManager/ServerApiManager';
33
import createCache from '../utils/createCache';
44

5-
const { services, timeouts } = require('__APP_CONFIG__');
5+
const { services, serviceConfigs } = require('__APP_CONFIG__');
66

7-
const cache = createCache(ServerApiManager, services, timeouts.serverApiManager);
7+
const cache = createCache(ServerApiManager, services, serviceConfigs?.server);
88

99
export default cache;

src/universal/partials/Welcome/partials.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import components from '../../core/route/components';
22

3-
const previewPages = require('__V_PREVIEW_PAGES__');
3+
const preview = require('__V_PREVIEW__');
44

55
const partials = [];
66
const BLACKLIST = ['REQUEST_DISPATCHER'];
@@ -14,7 +14,7 @@ Object.keys(components).forEach(path => {
1414
});
1515
}
1616
});
17-
const pages = previewPages?.default?.pages || [];
17+
const pages = preview?.default?.pages || [];
1818
partials.push(...pages);
1919

2020
export default partials;

0 commit comments

Comments
 (0)