Skip to content

Commit 770b646

Browse files
authored
Make config param function returns consistent (#799)
1 parent 099eff6 commit 770b646

File tree

3 files changed

+14
-13
lines changed

3 files changed

+14
-13
lines changed

test/model/test_node.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2522,9 +2522,8 @@ async def test_set_raw_config_parameter_value(
25222522
{},
25232523
)
25242524

2525-
assert await node.async_set_raw_config_parameter_value(
2526-
1, 101, 1
2527-
) == SetConfigParameterResult(CommandStatus.QUEUED)
2525+
_, result = await node.async_set_raw_config_parameter_value(1, 101, 1)
2526+
assert result == SetConfigParameterResult(CommandStatus.QUEUED)
25282527

25292528
assert len(ack_commands) == 1
25302529

@@ -2540,9 +2539,10 @@ async def test_set_raw_config_parameter_value(
25402539
"messageId": uuid4,
25412540
}
25422541

2543-
assert await node.async_set_raw_config_parameter_value(
2542+
_, result = await node.async_set_raw_config_parameter_value(
25442543
"Disable", "Stay Awake in Battery Mode"
2545-
) == SetConfigParameterResult(CommandStatus.QUEUED)
2544+
)
2545+
assert result == SetConfigParameterResult(CommandStatus.QUEUED)
25462546

25472547
assert len(ack_commands) == 2
25482548

@@ -2563,9 +2563,10 @@ async def test_set_raw_config_parameter_value(
25632563
)
25642564
node.receive_event(event)
25652565

2566-
assert await node.async_set_raw_config_parameter_value(
2566+
_, result = await node.async_set_raw_config_parameter_value(
25672567
1, 2, value_size=1, value_format=ConfigurationValueFormat.SIGNED_INTEGER
2568-
) == SetConfigParameterResult(CommandStatus.ACCEPTED)
2568+
)
2569+
assert result == SetConfigParameterResult(CommandStatus.ACCEPTED)
25692570

25702571
assert len(ack_commands) == 3
25712572

@@ -2614,7 +2615,7 @@ async def test_supervision_result(inovelli_switch: node_pkg.Node, uuid4, mock_co
26142615
{"result": {"status": 1, "remainingDuration": "default"}},
26152616
)
26162617

2617-
result = await node.async_set_raw_config_parameter_value(1, 1)
2618+
_, result = await node.async_set_raw_config_parameter_value(1, 1)
26182619
assert result.result.status is SupervisionStatus.WORKING
26192620
duration = result.result.remaining_duration
26202621
assert duration.unit == "default"

zwave_js_server/model/endpoint.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ async def async_set_raw_config_parameter_value(
294294
property_key: int | None = None,
295295
value_size: Literal[1, 2, 4] | None = None,
296296
value_format: ConfigurationValueFormat | None = None,
297-
) -> SetConfigParameterResult:
297+
) -> tuple[Value, SetConfigParameterResult]:
298298
"""Send setRawConfigParameterValue."""
299299
try:
300300
zwave_value = next(
@@ -361,11 +361,11 @@ async def async_set_raw_config_parameter_value(
361361
)
362362

363363
if data is None:
364-
return SetConfigParameterResult(CommandStatus.QUEUED)
364+
return zwave_value, SetConfigParameterResult(CommandStatus.QUEUED)
365365

366366
if (result := data.get("result")) is None:
367-
return SetConfigParameterResult(CommandStatus.ACCEPTED)
367+
return zwave_value, SetConfigParameterResult(CommandStatus.ACCEPTED)
368368

369-
return SetConfigParameterResult(
369+
return zwave_value, SetConfigParameterResult(
370370
CommandStatus.ACCEPTED, SupervisionResult(result)
371371
)

zwave_js_server/model/node/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -952,7 +952,7 @@ async def async_set_raw_config_parameter_value(
952952
property_key: int | None = None,
953953
value_size: Literal[1, 2, 4] | None = None,
954954
value_format: ConfigurationValueFormat | None = None,
955-
) -> SetConfigParameterResult | None:
955+
) -> tuple[Value, SetConfigParameterResult | None]:
956956
"""Send setRawConfigParameterValue."""
957957
return await self.endpoints[0].async_set_raw_config_parameter_value(
958958
new_value, property_, property_key, value_size, value_format

0 commit comments

Comments
 (0)