Handle wait for result concerns (#744)

* Handle wait for result concerns

* fix test

* Add coverage

* fix tests

Author: raman325

test/model/test_node.py

@@ -2199,15 +2199,17 @@ async def test_manually_idle_notification_value(
         await node.async_manually_idle_notification_value(f"{node.node_id}-112-0-255")
 
 
-async def test_set_date_and_time(multisensor_6: node_pkg.Node, uuid4, mock_command):
-    """Test node.set_date_and_time command."""
+async def test_set_date_and_time_no_wait(
+    multisensor_6: node_pkg.Node, uuid4, mock_command
+):
+    """Test node.set_date_and_time command without waiting."""
     node = multisensor_6
     ack_commands = mock_command(
         {"command": "node.set_date_and_time", "nodeId": node.node_id},
         {"success": True},
     )
 
-    assert await node.async_set_date_and_time(datetime(2020, 1, 1, 12, 0, 0))
+    assert await node.async_set_date_and_time(datetime(2020, 1, 1, 12, 0, 0)) is None
 
     assert len(ack_commands) == 1
     assert ack_commands[0] == {
@@ -2217,9 +2219,26 @@ async def test_set_date_and_time(multisensor_6: node_pkg.Node, uuid4, mock_comma
         "messageId": uuid4,
     }
 
-    # Raise ValueError if the value is not for the right CommandClass
-    with pytest.raises(ValueError):
-        await node.async_manually_idle_notification_value(f"{node.node_id}-112-0-255")
+
+async def test_set_date_and_time(
+    climate_radio_thermostat_ct100_plus: node_pkg.Node, uuid4, mock_command
+):
+    """Test node.set_date_and_time command while waiting for response."""
+    node = climate_radio_thermostat_ct100_plus
+    ack_commands = mock_command(
+        {"command": "node.set_date_and_time", "nodeId": node.node_id},
+        {"success": True},
+    )
+
+    assert await node.async_set_date_and_time(datetime(2020, 1, 1, 12, 0, 0))
+
+    assert len(ack_commands) == 1
+    assert ack_commands[0] == {
+        "command": "node.set_date_and_time",
+        "nodeId": node.node_id,
+        "date": "2020-01-01T12:00:00",
+        "messageId": uuid4,
+    }
 
 
 async def test_get_date_and_time(multisensor_6: node_pkg.Node, uuid4, mock_command):

zwave_js_server/model/node/__init__.py

@@ -621,7 +621,7 @@ async def async_get_firmware_update_capabilities_cached(
 
     async def async_abort_firmware_update(self) -> None:
         """Send abortFirmwareUpdate command to Node."""
-        await self.async_send_command("abort_firmware_update", wait_for_result=True)
+        await self.async_send_command("abort_firmware_update", wait_for_result=False)
 
     async def async_poll_value(self, val: Value | str) -> None:
         """Send pollValue command to Node for given value (or value_id)."""
@@ -855,7 +855,9 @@ async def async_manually_idle_notification_value(self, val: Value | str) -> None
             wait_for_result=False,
         )
 
-    async def async_set_date_and_time(self, datetime_: datetime | None = None) -> bool:
+    async def async_set_date_and_time(
+        self, datetime_: datetime | None = None, wait_for_result: bool | None = None
+    ) -> bool | None:
         """Send setDateAndTime command to Node."""
         args = {}
         if datetime_:
@@ -864,10 +866,11 @@ async def async_set_date_and_time(self, datetime_: datetime | None = None) -> bo
             "set_date_and_time",
             **args,
             require_schema=28,
-            wait_for_result=True,
+            wait_for_result=wait_for_result,
         )
-        assert data
-        return cast(bool, data["success"])
+        if data:
+            return cast(bool, data["success"])
+        return None
 
     async def async_get_date_and_time(self) -> DateAndTime:
         """Send getDateAndTime command to Node."""
@@ -894,7 +897,7 @@ async def async_abort_health_check(self) -> None:
         await self.async_send_command(
             "abort_health_check",
             require_schema=31,
-            wait_for_result=True,
+            wait_for_result=False,
         )
 
     async def async_set_default_volume(