-
Notifications
You must be signed in to change notification settings - Fork 279
Description
Building on the existing workflows and project layout, I've made a few more attempts at improving how different workspaces work together. The two issues I am currently looking into are
- Be able to run CI workflows against both
hono@3andhono@4, for the packages that can - Use the
workspace:protocol for the dependency between@hono/zod-openapiand@hono/zod-validator
I've made an attempt both with yarn and bun. In both instances I've moved hono to the root package.json and kept it as a peer dependency in each workspace. This allows each CI workflow to pick a specific version to run the build and tests against.
This mostly works, which is encouraging!
One problem is that when hono@3 is installed, vitest fails due to hono/jsx/dom/client only existing in hono@4. This is probably easy to fix by keeping hono@4 as a dev dependencies in @hono/react-compat.
Another issue I've run into, although bun does have some support for workspaces, yarn appears to be much better support for workspaces. Yarn has it's own quirks.. but my initial impressions are that it'll be simpler to solve the 2 points above with yarn.
Please let me know if you have any thoughts/opinions/questions. Hopefully the two PRs I've linked have enough detail