Skip to content

Commit cadf5cd

Browse files
chore: update ci.buld.yml (#476)
* fix(security): remediate workflow vulnerability in .github/workflows/ci.buld.yml * Apply suggestion from @paulinebm * Apply suggestion from @paulinebm --------- Co-authored-by: hf-security-analysis[bot] <265538906+hf-security-analysis[bot]@users.noreply.github.com> Co-authored-by: Pauline Bailly-Masson <155966238+paulinebm@users.noreply.github.com>
1 parent fdf55a2 commit cadf5cd

1 file changed

Lines changed: 3 additions & 7 deletions

File tree

‎.github/workflows/ci.buld.yml‎

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,6 @@ jobs:
5151
run: |
5252
5353
echo "IMAGE_TAG=${GITHUB_REF##*/}" >> $GITHUB_ENV
54-
echo "DOCKER_USERNAME=$DOCKER_USERNAME" >> $GITHUB_ENV
55-
echo "DOCKER_PASSWORD=$DOCKER_PASSWORD" >> $GITHUB_ENV
5654
if [[ $IS_MAIN == 'true' ]]; then
5755
echo "DOCKER_IMAGE=aisheets/sheets" >> $GITHUB_ENV
5856
echo "PLATFORMS=linux/amd64,linux/arm64" >> $GITHUB_ENV
@@ -65,17 +63,15 @@ jobs:
6563
echo "PLATFORMS=linux/amd64" >> $GITHUB_ENV
6664
fi
6765
env:
68-
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
69-
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
7066
IS_RELEASE: ${{ startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/stable' }}
7167
IS_MAIN: ${{ github.ref == 'refs/heads/main' }}
7268

7369

7470
- name: Login to Docker Hub
7571
uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3
7672
with:
77-
username: ${{ env.DOCKER_USERNAME }}
78-
password: ${{ env.DOCKER_PASSWORD }}
73+
username: ${{ secrets.DOCKER_USERNAME }}
74+
password: ${{ secrets.DOCKER_PASSWORD }}
7975

8076
- name: Build and push image
8177
uses: docker/build-push-action@ca052bb54ab0790a636c9b5f226502c73d547a25 # v5
@@ -92,4 +88,4 @@ jobs:
9288
platforms: ${{ env.PLATFORMS }}
9389
tags: ${{ env.DOCKER_IMAGE }}:latest
9490
labels: ${{ steps.meta.outputs.labels }}
95-
push: true
91+
push: true

0 commit comments

Comments
 (0)