fix: resolve internal links against baseURL for non-root deployments

Several internal links (e.g. in navbar.html, footer.html,
cards/project.html) used plain {{ .url }} without baseURL handling.
This only worked when baseURL had no subpath; it breaks on any
non-root deployment, e.g. some site served from "person.dev/me/" rather
than the domain root "person.dev".

The problematic call sites now distinguish external (http/https) URLs
(left untouched) from internal ones, which are now resolved via a new
`helpers/get-page-url.html` partial. `helpers/get-section-url.html`
is refactored to use the same helper instead of inlining
`site.BaseURL | relLangURL` directly. The brand, home, blog, and notes
links in navbar.html, which already inlined this same
`path.Join (site.BaseURL | relLangURL) ...` pattern ad hoc, are
likewise refactored onto the shared helper, so there is now a single
place that resolves internal links against baseURL.

Author: yinchi

layouts/partials/cards/project.html

@@ -4,8 +4,13 @@
       {{- $target := .target | default "blank" -}}
       {{- $targetAttr := "_blank" -}}
       {{- if eq $target "self" -}}{{- $targetAttr = "_self" -}}{{- end -}}
-      <a href="{{ if .repo }}{{ .repo }}{{ else if .url }}{{ .url }}{{ else }}javascript:void(0){{ end }}" {{ if or
-        .repo .url }}target="{{ $targetAttr }}" rel="noopener" {{ end }}>
+      {{/* Process internal links (not http[s]://) */}}
+      {{- $projectURL := .url -}}
+      {{- if and $projectURL (not (or (hasPrefix $projectURL "http://") (hasPrefix $projectURL "https://"))) -}}
+        {{- $projectURL = partial "helpers/get-page-url.html" $projectURL -}}
+      {{- end -}}
+      <a href="{{ if .repo }}{{ .repo }}{{ else if $projectURL }}{{ $projectURL }}{{ else }}javascript:void(0){{ end }}" {{ if or
+        .repo $projectURL }}target="{{ $targetAttr }}" rel="noopener" {{ end }}>
         {{ if .image }}
         <div class="card-head">
           {{ $imageImage:= resources.Get .image}}
@@ -80,9 +85,9 @@ <h5 class="card-title mb-0">{{ .name }}</h5>
             <!-- Place this tag where you want the button to render. -->
             <a class="github-button project-btn d-none" href="{{ .repo }}" data-icon="octicon-standard"
               data-show-count="true" aria-label="Star {{ .name }}">{{ i18n "project_star" }}</a>
-            {{ else if .url }}
+            {{ else if $projectURL }}
             <span>
-              <a class="btn btn-outline-info btn-sm" href="{{ .url }}" target="{{ $targetAttr }}" rel="noopener">{{ i18n "project_details" }}</a>
+              <a class="btn btn-outline-info btn-sm" href="{{ $projectURL }}" target="{{ $targetAttr }}" rel="noopener">{{ i18n "project_details" }}</a>
             </span>
             {{ end }}
           </div>

layouts/partials/footer.html

@@ -86,8 +86,13 @@ <h5>{{ i18n "navigation" }}</h5>
             {{ if $customMenusEnabled }}
               {{ range $customMenus }}
                 {{ if .showOnFooter }}
+                    {{ $menuURL := .url }}
+                    {{/* Process internal links (not http[s]://) */}}
+                    {{ if not (or (hasPrefix $menuURL "http://") (hasPrefix $menuURL "https://")) }}
+                      {{ $menuURL = partial "helpers/get-page-url.html" $menuURL }}
+                    {{ end }}
                     <li class="nav-item">
-                      <a class="smooth-scroll" href="{{ .url }}">{{ .name }}</a>
+                      <a class="smooth-scroll" href="{{ $menuURL }}">{{ .name }}</a>
                     </li>
                 {{ end }}
               {{ end }}

layouts/partials/helpers/get-page-url.html

@@ -0,0 +1 @@
+{{- path.Join (site.BaseURL | relLangURL) (strings.Trim . "/") -}}

layouts/partials/helpers/get-section-url.html

@@ -1,5 +1,5 @@
 {{- if page.IsHome -}}
     #{{ partial "helpers/get-section-id.html" . }}
 {{- else -}}
-    {{ site.BaseURL | relLangURL }}#{{ partial "helpers/get-section-id.html" . }}
-{{- end -}}
+    {{ partial "helpers/get-page-url.html" "" }}#{{ partial "helpers/get-section-id.html" . }}
+{{- end -}}

layouts/partials/navigators/navbar.html

@@ -79,7 +79,7 @@
       <i data-feather="sidebar"></i>
     </button>
     {{ end }}
-    <a class="navbar-brand" href="{{ site.BaseURL | relLangURL }}">
+    <a class="navbar-brand" href="{{ partial "helpers/get-page-url.html" "" }}">
       {{ if $logo }}
         <img src="{{ $logo }}" id="logo" alt="Logo">
       {{ end }}
@@ -99,7 +99,7 @@
     <div class="collapse navbar-collapse dynamic-navbar" id="top-nav-items">
       <ul class="nav navbar-nav ms-auto">
         <li class="nav-item">
-          <a class="nav-link" href="{{ if .IsHome }}#home{{else}}{{ site.BaseURL | relLangURL }}#home{{end}}">{{ i18n "home" }}</a>
+          <a class="nav-link" href="{{ if .IsHome }}#home{{else}}{{ partial "helpers/get-page-url.html" "" }}#home{{end}}">{{ i18n "home" }}</a>
         </li>
         {{ if $sections }}
           {{ $sectionCount := 1 }}
@@ -136,18 +136,23 @@
         {{ end }}
         {{ if $blogEnabled }}
           <li class="nav-item">
-            <a class="nav-link" id="blog-link" href="{{ path.Join (site.BaseURL | relLangURL) $blogSection }}">{{ $blogTitle }}</a>
+            <a class="nav-link" id="blog-link" href="{{ partial "helpers/get-page-url.html" $blogSection }}">{{ $blogTitle }}</a>
           </li>
         {{ end }}
         {{ if $notesEnabled }}
           <li class="nav-item">
-            <a class="nav-link" id="note-link" href="{{ path.Join (site.BaseURL | relLangURL) "notes" }}">{{ $notesTitle }}</a>
+            <a class="nav-link" id="note-link" href="{{ partial "helpers/get-page-url.html" "notes" }}">{{ $notesTitle }}</a>
           </li>
         {{ end }}
         {{ range $customMenus }}
             {{ if (not .hideFromNavbar) }}
+              {{ $menuURL := .url }}
+              {{/* Process internal links (not http[s]://) */}}
+              {{ if not (or (hasPrefix $menuURL "http://") (hasPrefix $menuURL "https://")) }}
+                {{ $menuURL = partial "helpers/get-page-url.html" $menuURL }}
+              {{ end }}
               <li class="nav-item">
-                <a class="nav-link" href="{{ .url }}">{{ .name }}</a>
+                <a class="nav-link" href="{{ $menuURL }}">{{ .name }}</a>
               </li>
             {{ end }}
         {{ end }}