renamed CriticalSection -> UniqueCriticalSection

Author: hugsy

.github/workflows/build.yml

@@ -29,7 +29,7 @@ jobs:
           - {os: windows-2022,   arch: win32,    config: RelWithDebInfo,  crypto: ON}
           - {os: windows-2022,   arch: win32,    config: RelWithDebInfo,  crypto: OFF}
           - {os: windows-2022,   arch: arm64,    config: RelWithDebInfo,  crypto: ON}
-          - {os: windows-2022,   arch: arm,      config: RelWithDebInfo,  crypto: ON}
+          # - {os: windows-2022,   arch: arm,      config: RelWithDebInfo,  crypto: ON} # ARM not supported any longer
           # - {os: ubuntu-2204,    arch: x64,      config: RelWithDebInfo} # runner fails for some reason, works fine locally: see https://github.com/actions/runner-images/discussions/7188
           # - {os: ubuntu-2204,    arch: x86,      config: RelWithDebInfo}
 

Modules/Common/Include/Handle.hpp

@@ -5,10 +5,9 @@
 #include "Common.hpp"
 
 ///
-/// Scope-managed handles
+/// @brief Scope-managed handles
 ///
 /// @ref https://andreasfertig.blog/2022/08/cpp-insights-lambdas-in-unevaluated-contexts/
-/// @link https://developercommunity.visualstudio.com/t/c20-internal-compiler-error-for-lambda-in-decltype/1631476
 ///
 template<typename T, auto Deleter>
 using GenericHandle = std::unique_ptr<
@@ -26,8 +25,30 @@ using GenericHandle = std::unique_ptr<
 #ifdef __linux__
 using UniqueHandle = GenericHandle<FILE, ::fclose>;
 #else
-using UniqueHandle        = GenericHandle<void, ::CloseHandle>;
+
+///
+/// @brief A unique (as-in `unique_ptr`) Windows handle. It will close itself on scope-exit.
+///
+using UniqueHandle = GenericHandle<void, ::CloseHandle>;
+
+///
+/// @brief A unique (as-in `unique_ptr`) Windows module handle.
+///
 using UniqueLibraryHandle = GenericHandle<HINSTANCE__, ::FreeLibrary>;
+
+///
+/// @brief A unique Windows Critical Section.
+///
+using UniqueCriticalSection = GenericHandle<
+    RTL_CRITICAL_SECTION,
+    [](RTL_CRITICAL_SECTION* p)
+    {
+        if ( p )
+        {
+            ::LeaveCriticalSection(p);
+            p = nullptr;
+        }
+    }>;
 #endif // __linux__
 
 using SharedHandle = std::shared_ptr<UniqueHandle>;

Modules/Process/Source/Win32/Process.cpp

@@ -27,13 +27,6 @@ usize
 GetPebLength();
 EXTERN_C_END
 
-using CriticalSection = GenericHandle<
-    RTL_CRITICAL_SECTION,
-    [](auto p)
-    {
-        ::LeaveCriticalSection(p);
-    }>;
-
 
 namespace pwn::Process
 {
@@ -590,12 +583,12 @@ Process::EnumerateLocalModules()
 {
     std::vector<LDR_DATA_TABLE_ENTRY> res;
     auto peb = Peb();
-    CriticalSection csLoaderLock {[&]()
-                                  {
-                                      auto lock = peb->LoaderLock;
-                                      ::EnterCriticalSection(lock);
-                                      return lock;
-                                  }()};
+    UniqueCriticalSection csLoaderLock {[&]()
+                                        {
+                                            auto lock = peb->LoaderLock;
+                                            ::EnterCriticalSection(lock);
+                                            return lock;
+                                        }()};
 
     if ( !peb->Ldr->Initialized )
         return Ok(res);