Skip to content

Commit 7dae022

Browse files
authored
Merge pull request #92 from donglei/fixed-gc
Logger improved for GC using
2 parents 6e830ec + 2aadd1f commit 7dae022

File tree

2 files changed

+23
-16
lines changed

2 files changed

+23
-16
lines changed

source/hunt/logging/ConsoleLogger.d

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import std.typecons;
3030
import std.traits;
3131

3232
alias LogLayoutHandler = string delegate(string time_prior, string tid, string level, string myFunc,
33-
string msg, string file, size_t line);
33+
string msg, string file, size_t line);
3434

3535
private {
3636
__gshared LogLayoutHandler _layoutHandler;
@@ -40,8 +40,10 @@ private {
4040
_layoutHandler = (string time_prior, string tid, string level, string fun,
4141
string msg, string file, size_t line) {
4242

43-
return time_prior ~ " | " ~ tid ~ " | " ~ level ~ " | " ~ fun ~ " | " ~ msg
44-
~ " | " ~ file ~ ":" ~ to!string(line);
43+
import std.format;
44+
return format("%s | %s | %s | %s | %s | %s:%d", time_prior, tid, level, fun, msg, file, line);
45+
/* return time_prior ~ " | " ~ tid ~ " | " ~ level ~ " | " ~ fun ~ " | " ~ msg
46+
~ " | " ~ file ~ ":" ~ to!string(line);*/
4547
};
4648
}
4749

@@ -234,7 +236,7 @@ class ConsoleLogger {
234236

235237
private static string layout(string file = __FILE__, size_t line = __LINE__,
236238
string func = __FUNCTION__)(string msg, string level) {
237-
enum lineNum = std.conv.to!string(line);
239+
//enum lineNum = std.conv.to!string(line);
238240
string time_prior = Clock.currTime.toString();
239241
string tid = std.conv.to!string(cast(size_t)getTid());
240242

@@ -250,12 +252,14 @@ class ConsoleLogger {
250252
fun = func[index + 1 .. $];
251253
}
252254

253-
LogLayoutHandler handler = layoutHandler();
254-
if(handler !is null) {
255-
return handler(time_prior, tid, level, fun, msg, file, line);
256-
} else {
257-
return time_prior ~ " | " ~ tid ~ " | " ~ level ~ " | " ~ fun ~ " | " ~ msg
258-
~ " | " ~ file ~ ":" ~ lineNum;
255+
LogLayoutHandler handler = layoutHandler();
256+
if(handler !is null) {
257+
return handler(time_prior, tid, level, fun, msg, file, line);
258+
} else {
259+
import std.format;
260+
return format("%s | %s | %s | %s | %s | %s:%d", time_prior, tid, level, fun, msg, file, line);
261+
/* return time_prior ~ " | " ~ tid ~ " | " ~ level ~ " | " ~ fun ~ " | " ~ msg
262+
~ " | " ~ file ~ ":" ~ lineNum;*/
259263
}
260264
}
261265

@@ -383,7 +387,7 @@ class ConsoleLogger {
383387

384388

385389
void setLogLayout(LogLayoutHandler handler) {
386-
_layoutHandler = handler;
390+
_layoutHandler = handler;
387391
}
388392

389393

source/hunt/logging/Logger.d

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,10 @@ LogLayoutHandler layoutHandler() {
4444
if(_layoutHandler is null) {
4545
_layoutHandler = (string time_prior, string tid, string level, string myFunc,
4646
string msg, string file, size_t line) {
47-
48-
return time_prior ~ " (" ~ tid ~ ") [" ~ level ~ "] " ~ myFunc ~
49-
" - " ~ msg ~ " - " ~ file ~ ":" ~ to!string(line);
47+
import std.format;
48+
return format("%s (%s) [%s] %s - %s - %s:%d", time_prior, tid, level, myFunc, msg, file, line);
49+
//return time_prior ~ " (" ~ tid ~ ") [" ~ level ~ "] " ~ myFunc ~
50+
// " - " ~ msg ~ " - " ~ file ~ ":" ~ to!string(line);
5051
};
5152
}
5253

@@ -591,8 +592,10 @@ protected:
591592
if(handler !is null) {
592593
return handler(time_prior, tid, toString(level), myFunc, msg, file, line);
593594
} else {
594-
return time_prior ~ " (" ~ tid ~ ") [" ~ toString(
595-
level) ~ "] " ~ myFunc ~ " - " ~ msg ~ " - " ~ file ~ ":" ~ to!string(line);
595+
/*return time_prior ~ " (" ~ tid ~ ") [" ~ toString(
596+
level) ~ "] " ~ myFunc ~ " - " ~ msg ~ " - " ~ file ~ ":" ~ to!string(line);*/
597+
import std.format;
598+
return format("%s | %s | %s | %s | %s | %s:%d", time_prior, tid, level, myFunc, msg, file, line);
596599
}
597600
}
598601

0 commit comments

Comments
 (0)