deadbeef: allow building without support for legacy artwork plugin

Author: hyperblast

cpp/extlibs/deadbeef/local/FindDeadbeef.cmake

@@ -1 +1,2 @@
+set(DEADBEEF_ARTWORK_LEGACY ON)
 set(DEADBEEF_INCLUDE_DIRS ${EXTLIB_INSTALL_DIR}/include)

cpp/extlibs/deadbeef/system/FindDeadbeef.cmake

@@ -1,3 +1,5 @@
+set(DEADBEEF_ARTWORK_LEGACY OFF)
+
 find_path(
     DEADBEEF_INCLUDE_DIRS
     NAMES deadbeef/deadbeef.h

cpp/server/deadbeef/CMakeLists.txt

@@ -7,7 +7,7 @@ include_directories(
 set(
     PLUGIN_SOURCES
     add_items_scope.cpp add_items_scope.hpp
-    artwork_fetcher_v1.cpp artwork_fetcher_v2.cpp artwork_fetcher.hpp
+    artwork_fetcher_v2.cpp artwork_fetcher.hpp
     common.cpp common.hpp
     player.hpp
     player_control.cpp
@@ -19,6 +19,16 @@ set(
     utils.cpp utils.hpp
 )
 
+if(DEADBEEF_ARTWORK_LEGACY)
+    add_definitions(-DDEADBEEF_ARTWORK_LEGACY)
+
+    set(
+        PLUGIN_SOURCES
+        ${PLUGIN_SOURCES}
+        artwork_fetcher_v1.cpp
+    )
+endif()
+
 add_library(
     deadbeef_plugin MODULE
     ${PLUGIN_SOURCES}

cpp/server/deadbeef/artwork_fetcher.hpp

@@ -13,7 +13,10 @@ class ArtworkFetcher
 
     virtual boost::unique_future<ArtworkResult> fetchArtwork(PlaylistPtr playlist, PlaylistItemPtr item) = 0;
 
+#ifdef DEADBEEF_ARTWORK_LEGACY
     static std::unique_ptr<ArtworkFetcher> createV1();
+#endif
+
     static std::unique_ptr<ArtworkFetcher> createV2();
 };
 

cpp/server/deadbeef/player_misc.cpp

@@ -82,10 +82,12 @@ void PlayerImpl::connect()
 
     artworkFetcher_ = ArtworkFetcher::createV2();
 
+#ifdef DEADBEEF_ARTWORK_LEGACY
     if (!artworkFetcher_)
     {
         artworkFetcher_ = ArtworkFetcher::createV1();
     }
+#endif
 }
 
 void PlayerImpl::disconnect()