someday I will stop minor tweaking

Author: hyperblast

src/Client/Infrastructure/RequestHandler.cs

@@ -201,14 +201,18 @@ private static async ValueTask ThrowResponseError(
     {
         if (response.Content.Headers.ContentType?.MediaType != ContentTypes.Json)
         {
-            throw PlayerClientException.Create(response);
+            throw PlayerClientException.Create(response.StatusCode, response.ReasonPhrase);
         }
 
         var errorResponse = (ErrorResponse?)await ParseResponse(
                 response, ErrorResponseType, DefaultSerializerOptions, true, cancellationToken)
             .ConfigureAwait(false);
 
-        throw PlayerClientException.Create(response, errorResponse?.Error?.Message, errorResponse?.Error?.Parameter);
+        throw PlayerClientException.Create(
+            response.StatusCode,
+            response.ReasonPhrase,
+            errorResponse?.Error?.Message,
+            errorResponse?.Error?.Parameter);
     }
 
     private static PlayerClientException InvalidResponse()

src/Client/PlayerClientException.cs

@@ -44,19 +44,20 @@ public PlayerClientException(
     }
 
     internal static PlayerClientException Create(
-        HttpResponseMessage message,
+        HttpStatusCode statusCode,
+        string? reasonPhrase = null,
         string? serverErrorMessage = null,
         string? errorParameterName = null)
     {
         var messageBuilder = new StringBuilder(150);
 
         messageBuilder.Append(
             CultureInfo.InvariantCulture,
-            $"Response status code does not indicate success: {(int)message.StatusCode}");
+            $"Response status code does not indicate success: {(int)statusCode}");
 
-        if (message.ReasonPhrase != null)
+        if (reasonPhrase != null)
         {
-            messageBuilder.Append($" ({message.ReasonPhrase})");
+            messageBuilder.Append($" ({reasonPhrase})");
         }
 
         messageBuilder.Append('.');
@@ -77,7 +78,7 @@ internal static PlayerClientException Create(
         return new PlayerClientException(
             messageBuilder.ToString(),
             HttpRequestError.Unknown,
-            message.StatusCode,
+            statusCode,
             serverErrorMessage,
             errorParameterName);
     }

tests/Client.Tests/PlayerClientExceptionTests.cs

@@ -1,6 +1,4 @@
 using System.Net;
-using System.Net.Http;
-using Beefweb.Client.Infrastructure;
 using FluentAssertions;
 using Xunit;
 
@@ -11,7 +9,7 @@ public class PlayerClientExceptionTests
     [Fact]
     public void Create_Simple()
     {
-        var exception = PlayerClientException.Create(new HttpResponseMessage(HttpStatusCode.MethodNotAllowed));
+        var exception = PlayerClientException.Create(HttpStatusCode.MethodNotAllowed, "Method Not Allowed");
         exception.Message.Should().Be("Response status code does not indicate success: 405 (Method Not Allowed).");
         exception.StatusCode.Should().Be(HttpStatusCode.MethodNotAllowed);
         exception.ServerErrorMessage.Should().BeNull();
@@ -22,7 +20,8 @@ public void Create_Simple()
     public void Create_WithServerMessage()
     {
         var exception = PlayerClientException.Create(
-            new HttpResponseMessage(HttpStatusCode.InternalServerError),
+            HttpStatusCode.InternalServerError,
+            "Internal Server Error",
             "it hits the fan");
 
         exception.Message.Should().Be(
@@ -37,8 +36,10 @@ public void Create_WithServerMessage()
     public void Create_WithServerMessage_WithParameterName()
     {
         var exception = PlayerClientException.Create(
-            new HttpResponseMessage(HttpStatusCode.BadRequest),
-            "parameter is required", "index");
+            HttpStatusCode.BadRequest,
+            "Bad Request",
+            "parameter is required",
+            "index");
 
         exception.Message.Should().Be(
             "Response status code does not indicate success: 400 (Bad Request). Server error: parameter is required. Parameter name: index.");