correctly handling escaping

Author: hyperblast

src/Client/ApiCredentials.cs

@@ -25,6 +25,9 @@ public record ApiCredentials(string User, string Password)
             return null;
 
         var parts = uri.UserInfo.Split(':', 2);
-        return new ApiCredentials(parts[0], parts.Length > 1 ? parts[1] : string.Empty);
+
+        return new ApiCredentials(
+            Uri.UnescapeDataString(parts[0]),
+            parts.Length > 1 ? Uri.UnescapeDataString(parts[1]) : string.Empty);
     }
 }

tests/Client.Tests/ApiCredentialsTests.cs

@@ -0,0 +1,27 @@
+using System;
+using FluentAssertions;
+using Xunit;
+
+namespace Beefweb.Client;
+
+public class ApiCredentialsTests
+{
+    [Fact]
+    public void FromUri_UnescapesValues()
+    {
+        const string userName = "User#";
+        const string password = "P@ssword";
+
+        var builder = new UriBuilder("http://localhost")
+        {
+            UserName = userName,
+            Password = password
+        };
+
+        var uri = builder.Uri;
+        var credentials = ApiCredentials.FromUri(uri);
+        credentials.Should().NotBeNull();
+        credentials!.User.Should().Be(userName);
+        credentials.Password.Should().Be(password);
+    }
+}