Skip to content

Conversation

@brandon-pereira
Copy link
Member

  • ignore next-env.d.ts from eslint - it's throwing errors but shouldn't be modified by the user
  • suppress next upgrade logging changes, currently it logs all api calls but this isn't necessary because pino logs on the backend

- ignore next-env.d.ts from eslint - it's throwing errors but shouldn't be modified by the user
- suppress next upgrade logging changes, currently it logs all api calls but this isn't necessary because pino logs on the backend
@brandon-pereira brandon-pereira requested review from a team and wrn14897 and removed request for a team December 15, 2025 22:42
@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2025

⚠️ No Changeset found

Latest commit: d2761b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Dec 15, 2025 10:47pm

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

E2E Test Results

All tests passed • 46 passed • 3 skipped • 639s

Status Count
✅ Passed 46
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

@claude
Copy link

claude bot commented Dec 15, 2025

PR Review

✅ No critical issues found.

The changes are clean and appropriate:

  • Adding next-env.d.ts to ESLint ignores is correct (auto-generated file, already in .gitignore)
  • Suppressing Next.js logging for /api/* routes is reasonable to avoid duplicate logging (Pino handles this on the backend)
  • Formatting changes follow standard practices (trailing commas, multi-line function parameters)

Minor note: The title has a typo ("live" → "life"), but this is cosmetic.

@kodiakhq kodiakhq bot merged commit 28dd5ce into main Dec 15, 2025
14 checks passed
@kodiakhq kodiakhq bot deleted the brandon/small-qol-fixes branch December 15, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants