Update to eslint 9

Author: jdesrosiers

.eslintrc.json

@@ -0,0 +1,48 @@
+import tseslint from "typescript-eslint";
+import stylistic from "@stylistic/eslint-plugin";
+import importPlugin from "eslint-plugin-import";
+
+
+export default tseslint.config(
+  ...tseslint.configs.recommendedTypeChecked,
+  ...tseslint.configs.stylisticTypeChecked,
+  importPlugin.flatConfigs.recommended, // eslint-disable-line @typescript-eslint/no-unsafe-argument, @typescript-eslint/no-unsafe-member-access
+  stylistic.configs.customize({
+    arrowParens: true,
+    braceStyle: "1tbs",
+    commaDangle: "never",
+    flat: true,
+    jsx: false,
+    quotes: "double",
+    semi: true
+  }),
+  {
+    languageOptions: {
+      parserOptions: {
+        projectService: true,
+        tsconfigRootDir: import.meta.dirname
+      }
+    },
+    settings: {
+      "import/resolver": {
+        typescript: {}
+      }
+    },
+    rules: {
+      // TypeScript
+      "@typescript-eslint/no-unused-vars": ["error", { caughtErrorsIgnorePattern: "^_" }],
+      "@typescript-eslint/no-empty-function": "off",
+      "@typescript-eslint/consistent-type-definitions": ["error", "type"],
+
+      // Imports
+      "import/extensions": ["error", "ignorePackages"],
+      // "import/newline-after-import": ["error", { count: 2, exactCount: false, considerComments: true }], // Doesn't respect @import
+
+      // Stylistic
+      "@stylistic/yield-star-spacing": ["error", "after"],
+      "@stylistic/multiline-ternary": "off",
+      "@stylistic/no-mixed-operators": "off",
+      "@stylistic/no-multiple-empty-lines": ["error", { max: 2, maxEOF: 0, maxBOF: 0 }] // Allow max=2 for imports
+    }
+  }
+);

eslint.config.js

@@ -1,5 +1,5 @@
 import { afterAll, beforeAll, describe, expect, test } from "vitest";
-import { TestClient } from "../../test/test-client.js";
+import { TestClient } from "../../test/test-client.ts";
 
 import type { DocumentSettings } from "../../services/configuration.js";
 
@@ -16,7 +16,7 @@ describe("Feature - Completion", () => {
     await client.stop();
   });
 
-  test("completion provider capabilities", async () => {
+  test("completion provider capabilities", () => {
     expect(client.serverCapabilities?.completionProvider).to.eql({
       resolveProvider: false,
       triggerCharacters: ["\"", ":", " "]

language-server/src/features/completion/completion.test.ts

@@ -1,6 +1,6 @@
 import { afterAll, afterEach, beforeAll, describe, expect, test } from "vitest";
 import { CompletionRequest } from "vscode-languageserver";
-import { TestClient } from "../../test/test-client.js";
+import { TestClient } from "../../test/test-client.ts";
 import { ifThenPatternCompletion } from "./if-then-completion.js";
 
 import type { DocumentSettings } from "../../services/configuration.js";

language-server/src/features/completion/if-then-completion.test.ts

@@ -1,6 +1,6 @@
 import { afterAll, afterEach, beforeAll, describe, expect, test } from "vitest";
 import { CompletionRequest, CompletionItemKind } from "vscode-languageserver";
-import { TestClient } from "../../test/test-client.js";
+import { TestClient } from "../../test/test-client.ts";
 
 import type { DocumentSettings } from "../../services/configuration.js";
 

language-server/src/features/completion/keyword-completion.test.ts

@@ -1,6 +1,6 @@
 import { afterAll, afterEach, beforeAll, describe, expect, test } from "vitest";
 import { CompletionItemKind, CompletionRequest } from "vscode-languageserver";
-import { TestClient } from "../../test/test-client.js";
+import { TestClient } from "../../test/test-client.ts";
 
 import type { DocumentSettings } from "../../services/configuration.js";
 

language-server/src/features/completion/schema-completion.test.ts

@@ -9,15 +9,15 @@ import * as SchemaNode from "../../model/schema-node.js";
 /** @implements DiagnosticsProvider */
 export class DeprecatedDiagnosticsProvider {
   /** @type DiagnosticsProvider["getDiagnostics"] */
-  async getDiagnostics(schemaDocument) {
+  async getDiagnostics(schemaDocument) { // eslint-disable-line @typescript-eslint/require-await
     const diagnostics = [];
 
     const annotationDialectUri = "https://json-schema.org/draft/2020-12/schema";
     for (const schemaResource of schemaDocument.schemaResources) {
       for (const deprecated of SchemaNode.annotatedWith(schemaResource, "deprecated", annotationDialectUri)) {
         if (SchemaNode.annotation(deprecated, "deprecated", annotationDialectUri).some((deprecated) => deprecated)) {
           diagnostics.push({
-            instance: deprecated.parent,
+            instance: deprecated.parent ?? deprecated,
             message: SchemaNode.annotation(deprecated, "x-deprecationMessage", annotationDialectUri).join("\n") || "deprecated",
             severity: DiagnosticSeverity.Warning,
             tags: [DiagnosticTag.Deprecated]

language-server/src/features/diagnostics/deprecated.js

@@ -1,6 +1,6 @@
 import { afterEach, beforeEach, describe, expect, test } from "vitest";
 import { DiagnosticSeverity, DiagnosticTag, PublishDiagnosticsNotification } from "vscode-languageserver";
-import { TestClient } from "../../test/test-client.js";
+import { TestClient } from "../../test/test-client.ts";
 
 import type { Diagnostic } from "vscode-languageserver";
 import type { DocumentSettings } from "../../services/configuration.js";
@@ -101,8 +101,8 @@ describe("Feature - Deprecated", () => {
 
     const diagnostics = await diagnosticsPromise;
     const expectedRange = {
-      "start": { "line": 2, "character": 4 },
-      "end": { "line": 2, "character": 21 }
+      start: { line: 2, character: 4 },
+      end: { line: 2, character: 21 }
     };
 
     expect(diagnostics[0]?.range).to.eql(expectedRange);

language-server/src/features/diagnostics/deprecated.test.ts

@@ -1,6 +1,6 @@
 import { afterEach, beforeEach, describe, expect, test } from "vitest";
 import { PublishDiagnosticsNotification } from "vscode-languageserver";
-import { TestClient } from "../../test/test-client.js";
+import { TestClient } from "../../test/test-client.ts";
 
 import type { Diagnostic } from "vscode-languageserver";
 import type { DocumentSettings } from "../../services/configuration.js";

language-server/src/features/diagnostics/validate-dialects.test.ts

@@ -24,11 +24,12 @@ export class ValidateReferencesDiagnosticsProvider {
 
     for (const schemaResource of schemaDocument.schemaResources) {
       for (const node of this.#schemas.references(schemaResource)) {
+        /** @type ReturnType<typeof SchemaNode.value<string>> */
         const reference = SchemaNode.value(node);
         let referencedSchema;
         try {
           referencedSchema = this.#schemas.getSchemaNode(reference, schemaResource) ?? await getSchema(reference);
-        } catch (error) {
+        } catch (_error) {
           // Ignore for now
         }