[ci] Report the earliest round for which there is a complete set of activity records

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Author: adetokunbo

apps/scan/src/main/openapi/scan.yaml

@@ -1628,7 +1628,7 @@ paths:
       description: |
         SV node internal API (CIP-0104, subject to change).
         Returns the earliest round for which CIP-0104 reward accounting activity
-        totals are available.
+        records are complete.
       responses:
         "200":
           description: ok

apps/scan/src/main/scala/org/lfdecentralizedtrust/splice/scan/ScanApp.scala

@@ -369,6 +369,7 @@ class ScanApp(
         automation,
         updateHistory,
         appRewardsStore,
+        appActivityRecordStoreO,
         acsSnapshotStore,
         scanEventStore,
         bulkStorage,

apps/scan/src/main/scala/org/lfdecentralizedtrust/splice/scan/admin/http/HttpScanHandler.scala

@@ -50,6 +50,7 @@ import org.lfdecentralizedtrust.splice.http.v0.scan.ScanResource
 import org.lfdecentralizedtrust.splice.http.v0.{definitions, scan as v0}
 import org.lfdecentralizedtrust.splice.scan.store.{
   AcsSnapshotStore,
+  AppActivityStore,
   ScanEventStore,
   ScanStore,
   TxLogEntry,
@@ -130,6 +131,7 @@ class HttpScanHandler(
     protected val storeWithIngestion: AppStoreWithIngestion[ScanStore],
     updateHistory: UpdateHistory,
     appRewardsStore: DbScanAppRewardsStore,
+    appActivityStoreO: Option[AppActivityStore],
     snapshotStore: AcsSnapshotStore,
     eventStore: ScanEventStore,
     bulkStorage: BulkStorage,
@@ -2377,14 +2379,23 @@ class HttpScanHandler(
   ] = {
     implicit val tc = extracted
     withSpan(s"$workflowId.getRewardAccountingEarliestAvailableRound") { _ => _ =>
-      appRewardsStore.getEarliestRoundWithActivityTotals().map {
-        case Some(round) =>
-          ScanResource.GetRewardAccountingEarliestAvailableRoundResponse.OK(
-            definitions.GetRewardAccountingEarliestAvailableRoundResponse(round)
-          )
+      appActivityStoreO match {
+        case Some(appActivityStore) =>
+          appActivityStore.earliestRoundWithCompleteAppActivity().map {
+            case Some(round) =>
+              ScanResource.GetRewardAccountingEarliestAvailableRoundResponse.OK(
+                definitions.GetRewardAccountingEarliestAvailableRoundResponse(round)
+              )
+            case None =>
+              ScanResource.GetRewardAccountingEarliestAvailableRoundResponse.NotFound(
+                ErrorResponse("No reward accounting data available yet")
+              )
+          }
         case None =>
-          ScanResource.GetRewardAccountingEarliestAvailableRoundResponse.NotFound(
-            ErrorResponse("No reward accounting data available yet")
+          Future.successful(
+            ScanResource.GetRewardAccountingEarliestAvailableRoundResponse.NotFound(
+              ErrorResponse("Reward accounting is not enabled")
+            )
           )
       }
     }

apps/scan/src/main/scala/org/lfdecentralizedtrust/splice/scan/automation/RewardComputationTrigger.scala

@@ -24,7 +24,7 @@ import scala.concurrent.{ExecutionContext, Future}
   *   2. Compute reward totals (CC minting allowances with threshold filtering)
   *   3. Build the Merkle tree of batched reward hashes
   *
-  * TODO(#4118): use ScanRewardsReferenceStore for synchronization in computeRewards needs it
+  * TODO(#4118): use ScanRewardsReferenceStore for synchronization when computeRewards requires it
   */
 class RewardComputationTrigger(
     appRewardsStore: ScanAppRewardsStore,

apps/scan/src/main/scala/org/lfdecentralizedtrust/splice/scan/store/db/DbScanAppRewardsStore.scala

@@ -477,18 +477,6 @@ class DbScanAppRewardsStore(
     )
   }
 
-  def getEarliestRoundWithActivityTotals()(implicit
-      tc: TraceContext
-  ): Future[Option[Long]] = {
-    val historyId = updateHistory.historyId
-    runQuerySingle(
-      sql"""select min(round_number) from #${Tables.appActivityRoundTotals}
-            where history_id = $historyId
-      """.as[Option[Long]].headOption.map(_.flatten),
-      "appRewards.getEarliestRoundWithActivityTotals",
-    )
-  }
-
   /** Runs the full reward computation pipeline for a single round.
     *
     * TODO(#4384): Will be extended to run CC conversion (stage 2) and

apps/scan/src/test/scala/org/lfdecentralizedtrust/splice/scan/store/DbScanAppRewardsStoreTest.scala

@@ -429,31 +429,7 @@ class DbScanAppRewardsStoreTest
       }
     }
 
-    // -- lookupLatestRoundWithRewardComputation / getEarliestRoundWithActivityTotals ------
-
-    "getEarliestRoundWithActivityTotals returns None when empty" in {
-      for {
-        (store, historyId) <- newStore()
-        result <- store.getEarliestRoundWithActivityTotals()
-      } yield {
-        result shouldBe None
-      }
-    }
-
-    "getEarliestRoundWithActivityTotals with data" in {
-      for {
-        (store, historyId) <- newStore()
-        _ <- insertSentinelRecords(historyId, 10L)
-        _ <- insertSentinelRecords(historyId, 20L)
-        _ <- insertActivityRecord(historyId, 10L, Seq("alice::provider"), Seq(100L))
-        _ <- insertActivityRecord(historyId, 20L, Seq("alice::provider"), Seq(200L))
-        _ <- store.aggregateActivityTotals(10L)
-        _ <- store.aggregateActivityTotals(20L)
-        earliest <- store.getEarliestRoundWithActivityTotals()
-      } yield {
-        earliest.value shouldBe 10L
-      }
-    }
+    // -- lookupLatestRoundWithRewardComputation ------
 
     "lookupLatestRoundWithRewardComputation returns None when no root hashes" in {
       for {