Skip to content

Conversation

@fab-10
Copy link
Contributor

@fab-10 fab-10 commented Oct 22, 2025

PR description

GC configuration tuning for Java25 to make it release the heap memory not used to the OS, and have pattern closer to Java21 (actually with this setup Java25 on average has less wasted heap) and base the Docker image on Java25

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

@fab-10 fab-10 force-pushed the java25-docker branch 4 times, most recently from 31eb4c3 to 2acefb8 Compare October 22, 2025 17:38
@fab-10 fab-10 changed the title Use OpenJDK 25 in Docker image Tune start script for OpenJDK 25 and use it in Docker image Oct 22, 2025
@fab-10 fab-10 marked this pull request as ready for review October 24, 2025 17:10
Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Also, we can probably use jlink command as a docker build step to prepare the JVM similar to how Temurin overview mentions (Consensys Web3Signer and Teku also uses similar approach) https://hub.docker.com/_/eclipse-temurin. This would ease up architect/checksum requirements.

@fab-10
Copy link
Contributor Author

fab-10 commented Oct 27, 2025

LGTM. Also, we can probably use jlink command as a docker build step to prepare the JVM similar to how Temurin overview mentions (Consensys Web3Signer and Teku also uses similar approach) https://hub.docker.com/_/eclipse-temurin. This would ease up architect/checksum requirements.

IDK about jlink could you propose a patch for that approach since you have already used it?

@fab-10 fab-10 marked this pull request as draft October 27, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants