Skip to content

Conversation

@macfarla
Copy link
Contributor

@macfarla macfarla commented Oct 24, 2025

PR description

eth_createAccessList should return success response even if tx reverted.
Discussion in json-rpc-api channel in discord, conclusion is

The access list should still be produced even if the call reverted. The intention of eth_createAccessList is just to capture all the accesses, it is not an endpoint that can be used to check if the transaction 'works'.

refer these commits to execution-apis repo
ethereum/execution-apis@f3544e8
ethereum/execution-apis@9772380

Fixed Issue(s)

Fixes this new hive test
eth_createAccessList/create-al-abi-revert
refs #5377

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

@macfarla macfarla added doc-change-required Indicates an issue or PR that requires doc to be updated RPC hive relating to hive tests labels Oct 24, 2025
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla added the breaking This can only be addressed/merged for a release that allows user-facing changes to be breaking. label Oct 27, 2025
@macfarla macfarla marked this pull request as draft October 27, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking This can only be addressed/merged for a release that allows user-facing changes to be breaking. doc-change-required Indicates an issue or PR that requires doc to be updated hive relating to hive tests RPC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants