Skip to content

layout/floating: fix "move" rule not using the size provided by the "size" rule - #16150

Open
sitiyou wants to merge 1 commit into
hyprwm:mainfrom
sitiyou:fix/move-rule
Open

layout/floating: fix "move" rule not using the size provided by the "size" rule#16150
sitiyou wants to merge 1 commit into
hyprwm:mainfrom
sitiyou:fix/move-rule

Conversation

@sitiyou

@sitiyou sitiyou commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Describe your PR, what does it fix/add?

Discussed in #13409

fixed a regression introduced by 7238703 where the computed size was used to update realPosition

// before src/desktop/view/Window.cpp
const auto COMPUTED = calculateExpression(m_ruleApplicator->static_.size);
// ...
*m_realSize = *COMPUTED;

// regression src/layout/algorithm/floating/default/DefaultFloatingAlgorithm.cpp
const auto COMPUTED = WINDOW->calculateExpression(*WINDOW->m_ruleApplicator->static_.size);
// ...
WINDOW->m_realPosition->setValueAndWarp(*COMPUTED);

e7996dc renames m_realPosition/m_realSize to positionAnimation()/sizeAnimation() with no functional change

vaxerski
vaxerski previously approved these changes Sep 7, 2026
@vaxerski

vaxerski commented Sep 7, 2026

Copy link
Copy Markdown
Member

can we get a regression test here?

@sitiyou
sitiyou force-pushed the fix/move-rule branch 2 times, most recently from 8d845f0 to ffd451c Compare September 7, 2026 17:00
…size" rule

fix a regression introduced by 72387033 where the computed size was used to update realPosition

e7996dc renames m_realPosition/m_realSize to positionAnimation()/sizeAnimation() with no functional change
@sitiyou

sitiyou commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

can we get a regression test here?

Done.

Without a final /reload the CI randomly fails, idk why.

@ItsOhen

ItsOhen commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

can we get a regression test here?

Done.

Without a final /reload the CI randomly fails, idk why.

May i ask why you need the new headless output when you don't check what output the window is on?

@sitiyou

sitiyou commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

can we get a regression test here?

Done.
Without a final /reload the CI randomly fails, idk why.

May i ask why you need the new headless output when you don't check what output the window is on?

I need to verify the window's position and size, so I need an output with a deterministic position and resolution to test against.

@vaxerski

Copy link
Copy Markdown
Member

you can query the monitor's pos and size and parse that.

Also conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants