layout/floating: fix "move" rule not using the size provided by the "size" rule - #16150
Open
sitiyou wants to merge 1 commit into
Open
layout/floating: fix "move" rule not using the size provided by the "size" rule#16150sitiyou wants to merge 1 commit into
sitiyou wants to merge 1 commit into
Conversation
vaxerski
previously approved these changes
Sep 7, 2026
Member
|
can we get a regression test here? |
sitiyou
force-pushed
the
fix/move-rule
branch
2 times, most recently
from
September 7, 2026 17:00
8d845f0 to
ffd451c
Compare
…size" rule fix a regression introduced by 72387033 where the computed size was used to update realPosition e7996dc renames m_realPosition/m_realSize to positionAnimation()/sizeAnimation() with no functional change
sitiyou
force-pushed
the
fix/move-rule
branch
from
September 8, 2026 09:01
ffd451c to
22ebe04
Compare
Contributor
Author
Done. Without a final |
Contributor
May i ask why you need the new headless output when you don't check what output the window is on? |
Contributor
Author
I need to verify the window's position and size, so I need an output with a deterministic position and resolution to test against. |
Member
|
you can query the monitor's pos and size and parse that. Also conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Discussed in #13409
fixed a regression introduced by 7238703 where the computed size was used to update realPosition
e7996dc renames
m_realPosition/m_realSizetopositionAnimation()/sizeAnimation()with no functional change