Failed to upload image: 400 Bad Request

[zhaoguoyuan]

require 'etsy'
Etsy.silent_errors = false
Etsy.api_key='xxxx'
Etsy.api_secret='xxxx'
Etsy.protocol = 'https'
access = {:access_token => 'xxxx', :access_secret => 'xxxx'}
listing = Etsy::Listing.find(yyyy)
Etsy::Image.create(listing, 'C:/temp/test.jpg', access)

=> #<Etsy::Response:0x2e4b338 @raw_response=#<Net::HTTPBadRequest 400 Bad Request readbody=true>>

Other calling of api all works fine.

I debugged it, the body of raw_response said "please make sure both width and height are greater than 10px", but I am quite sure that test.jpg satisfy this condition.

[zhaoguoyuan]

I think I have found out the solution(bug):

fix:
secure_client.rb:
Before change:

value.read

After change:

open(value.path, "rb") {|io| io.read }

Cause:
The reason is that for reading binary file value.read won't work on windwos. For ruby > 1.9.2 we can also read binary file with IO.binread, but for compatibility this solution should be fine.

Concern:
I havn't test this on other platform yet.

[kytrinyx]

Thanks for figuring it out. Do you want to submit a fix, or should I go ahead and make the change?

[zhaoguoyuan]

It is my pleasure to submit a fix, but please let me test it also on other platform first.

[kytrinyx]

Excellent. I can test it on Mac. Linux as well, though it requires a little bit more setup.

[zhaoguoyuan]

Ahh, it would be very helpful if you can, thank you in advance.

[kytrinyx]

I tested the open(value.path, "rb") {|io| io.read } and it is going to work just fine on Mac.

[zhaoguoyuan]

Can I have the permission for committing the new fixing branch?

[kytrinyx]

If you have a fork of the repository you can submit a pull request.

[zhaoguoyuan]

Sorry, do you means fork a repository, create a bug fix branch , fix it on the new branch and pull request on that repository?

[kytrinyx]

Yes:

1. Create a fork of this repository: https://github.com/kytrinyx/etsy/fork
2. Create a bugfix branch on the new fork (which will be https://github.com/zhaoguoyuan/etsy)
3. When you push to that branch, there will be a button to create a pull request, which will go back to this repository