Merge pull request #88 from identique/idnumbers-node-issue-84

fix(#84): fix over-validation rejecting valid IDs in DNK, CAN, ALB

Author: AngusHsu

examples/basic-usage-extended.ts

@@ -65,7 +65,7 @@ const multipleResults = validateMultipleIds([
   { countryCode: 'GBR', idNumber: 'AB123456C' },
   { countryCode: 'GBR', idNumber: 'DA123456C' }, // Invalid (starts with D)
   { countryCode: 'CAN', idNumber: '123456782' },
-  { countryCode: 'CAN', idNumber: '012345678' }, // Invalid (starts with 0)
+  { countryCode: 'CAN', idNumber: '012345678' }, // Invalid (checksum fails)
   { countryCode: 'DEU', idNumber: '12345678901' }
 ]);
 

src/__tests__/country-specific-validation.test.ts

@@ -179,9 +179,9 @@ describe('Python idnumbers test cases validation', () => {
   });
 
   describe('CAN - Social Insurance Number', () => {
-    const validCanadianSINs = ['123-456-782', '123456782'];
+    const validCanadianSINs = ['123-456-782', '123456782', '130692544', '046454286', '812345676'];
 
-    const invalidCanadianSINs = ['123-456-789', '000-000-000', '800-000-000'];
+    const invalidCanadianSINs = ['123-456-789', '130692545', '800-000-000'];
 
     test.each(validCanadianSINs)('should validate valid SIN: %s', sin => {
       const result = validateNationalId('CAN', sin);
@@ -454,7 +454,7 @@ describe('European country validations from Python tests', () => {
     { country: 'BEL', valid: ['93051822361'], invalid: ['93051822362'] },
     { country: 'AUT', valid: ['1237 010180', '1237010180'], invalid: ['1237 010181'] },
     { country: 'CZE', valid: ['7103192745'], invalid: ['7103192746'] },
-    { country: 'DNK', valid: ['0101701234'], invalid: ['0101701235'] },
+    { country: 'DNK', valid: ['0101701234', '0101701235', '061085-1178'], invalid: ['3201701234'] },
     { country: 'FIN', valid: ['131052-308T'], invalid: ['131052-308U'] },
     // NOR and HUN test data is invalid - these IDs return False in Python library too
     // { country: 'NOR', valid: ['01010150385'], invalid: ['01010150386'] },

src/__tests__/low-coverage-countries.test.ts

@@ -152,6 +152,8 @@ describe('Low Coverage Countries - Comprehensive Tests', () => {
       'J50101001A', // Male, born 1995-01-01
       'K55201002B', // Female, born 1995-02-01 (month + 50 for female)
       'L60315003C', // Male, born 1996-03-15
+      'I90308094A', // Python test vector, born 1989-03-08
+      '050308094A', // Year 1805 (no year clamping)
     ];
 
     const invalidIDs = [
@@ -189,6 +191,17 @@ describe('Low Coverage Countries - Comprehensive Tests', () => {
         expect(result.gender).toBe('female');
       }
     });
+
+    test('should parse year without clamping (year < 1900)', () => {
+      const result = parseIdInfo('ALB', '050308094A');
+      expect(result).not.toBeNull();
+      if (result) {
+        expect(result.birthDate.getFullYear()).toBe(1805);
+        expect(result.birthDate.getMonth()).toBe(2); // March (0-indexed)
+        expect(result.birthDate.getDate()).toBe(8);
+        expect(result.gender).toBe('male');
+      }
+    });
   });
 
   describe('COL - Colombia NUIP', () => {

src/__tests__/validateNationalId-migration.test.ts

@@ -46,7 +46,7 @@ describe('validateNationalId parity (registry vs old switch)', () => {
     {
       code: 'CAN',
       validId: '123456782',
-      invalidId: '000000000',
+      invalidId: '130692545',
       hasParse: false,
       description: 'Canada SIN',
     },

src/countries/alb/index.ts

@@ -22,17 +22,15 @@ export const METADATA = {
     'NID',
     'Numri i Identitetit të Shtetasit',
     'NISH',
-    'NIPT'
+    'NIPT',
   ],
   iso3166Alpha2: 'AL',
   minLength: 10,
   maxLength: 10,
   pattern: /^(?<yy>[0-9A-T]\d)(?<mm>\d{2})(?<dd>\d{2})(?<sn>\d{3})[-]?(?<checksum>[A-W])$/,
-  hasChecksum: true,
+  hasChecksum: false,
   isParsable: true,
-  links: [
-    'https://en.wikipedia.org/wiki/National_identification_number#Albania'
-  ]
+  links: ['https://en.wikipedia.org/wiki/National_identification_number#Albania'],
 };
 
 const BASE_YEAR_MAP = '0123456789ABCDEFGHIJKLMNOPQRST';
@@ -69,49 +67,37 @@ export function parse(idNumber: string): AlbaniaParseResult | null {
 
   try {
     const { yy, mm, dd, sn, checksum } = match.groups;
-    
+
     // Calculate year from base year map
     const yearBase = 1800 + BASE_YEAR_MAP.indexOf(yy[0]) * 10;
     const year = yearBase + parseInt(yy[1], 10);
-    
-    // Adjust for reasonable years (1900-2099)
-    const currentYear = new Date().getFullYear();
-    let adjustedYear = year;
-    
-    if (year > currentYear + 10) {
-      // If year is too far in future, it's likely from previous century
-      adjustedYear = year - 100;
-    } else if (year < 1900) {
-      // If year is before 1900, it's likely from current/next century
-      adjustedYear = year + 100;
-    }
-    
+
     // Parse month and determine gender
     const monthValue = parseInt(mm, 10);
-    const actualMonth = monthValue <= 12 ? monthValue : monthValue - 50;
-    const gender: 'male' | 'female' = monthValue <= 12 ? 'male' : 'female';
-    
+    const actualMonth = monthValue < 50 ? monthValue : monthValue - 50;
+    const gender: 'male' | 'female' = monthValue < 50 ? 'male' : 'female';
+
     const day = parseInt(dd, 10);
-    
+
     // Validate date
-    if (!isValidDate(adjustedYear, actualMonth, day)) {
+    if (!isValidDate(year, actualMonth, day)) {
       return null;
     }
-    
-    const birthDate = new Date(adjustedYear, actualMonth - 1, day);
-    
+
+    const birthDate = new Date(year, actualMonth - 1, day);
+
     // Validate checksum
     if (!validateChecksum(idNumber.substring(0, 9), checksum)) {
       return null;
     }
-    
+
     return {
       isValid: true,
       birthDate,
       gender,
       serialNumber: sn,
       checksum,
-      age: calculateAge(birthDate)
+      age: calculateAge(birthDate),
     };
   } catch {
     return null;
@@ -121,5 +107,5 @@ export function parse(idNumber: string): AlbaniaParseResult | null {
 export const IdentityNumber = {
   validate,
   parse,
-  METADATA
+  METADATA,
 };

src/countries/can/socialInsurance.ts

@@ -20,9 +20,9 @@ export class SocialInsuranceNumber implements IdNumberClass {
     links: [
       'https://en.wikipedia.org/wiki/Social_Insurance_Number',
       'https://www.canada.ca/en/employment-social-development/services/sin.html',
-      'http://www.straightlineinternational.com/docs/vaildating_canadian_sin.pdf'
+      'http://www.straightlineinternational.com/docs/vaildating_canadian_sin.pdf',
     ],
-    deprecated: false
+    deprecated: false,
   };
 
   private static readonly MULTIPLIER = [1, 2, 1, 2, 1, 2, 1, 2, 1];
@@ -42,11 +42,6 @@ export class SocialInsuranceNumber implements IdNumberClass {
 
     const normalized = idNumber.replace(/[-\s]/g, '');
 
-    // SIN cannot start with 0 or 8
-    if (normalized[0] === '0' || normalized[0] === '8') {
-      return false;
-    }
-
     return SocialInsuranceNumber.checksumValidate(normalized);
   }
 
@@ -61,7 +56,9 @@ export class SocialInsuranceNumber implements IdNumberClass {
    */
   private static checksumValidate(idNumber: string): boolean {
     const numberList = idNumber.split('').map(char => parseInt(char, 10));
-    const multipliedList = numberList.map((value, index) => value * SocialInsuranceNumber.MULTIPLIER[index]);
+    const multipliedList = numberList.map(
+      (value, index) => value * SocialInsuranceNumber.MULTIPLIER[index]
+    );
 
     // For each number, if it's > 9, add the two digits together (e.g., 14 -> 1+4 = 5)
     const sum = multipliedList.reduce((total, num) => {
@@ -77,7 +74,10 @@ export class SocialInsuranceNumber implements IdNumberClass {
    */
   static checksum(idNumber: string): CheckDigit {
     const normalized = idNumber.replace(/[-\s]/g, '');
-    const digits = normalized.slice(0, 8).split('').map(char => parseInt(char, 10));
+    const digits = normalized
+      .slice(0, 8)
+      .split('')
+      .map(char => parseInt(char, 10));
 
     let sum = 0;
     for (let i = 0; i < 8; i++) {
@@ -91,4 +91,4 @@ export class SocialInsuranceNumber implements IdNumberClass {
   checksum(idNumber: string): CheckDigit {
     return SocialInsuranceNumber.checksum(idNumber);
   }
-}
+}

src/countries/dnk/index.ts

@@ -6,13 +6,11 @@
  * - DD: Day of birth (01-31)
  * - MM: Month of birth (01-12)
  * - YY: Year of birth (last 2 digits)
- * - SSSS: Serial number (4 digits, last digit is checksum)
+ * - SSSS: Serial number (4 digits)
  *
- * NOTE: This implementation uses the CORRECT 10-digit format.
- * The Python idnumbers library incorrectly uses an 8-digit format,
- * but the official Danish CPR format is 10 digits as documented at:
+ * CPR numbers issued after 1 October 2007 do not use check digits,
+ * so checksum validation is not applied.
  * https://en.wikipedia.org/wiki/Personal_identification_number_(Denmark)
- * https://www.cpr.dk/
  */
 
 import { ValidationResult, ParsedInfo } from '../../types';
@@ -31,43 +29,11 @@ export const METADATA = {
   minLength: 10,
   maxLength: 10,
   pattern: /^(?<dd>\d{2})(?<mm>\d{2})(?<yy>\d{2})-?(?<sn>\d{4})$/,
-  hasChecksum: true,
+  hasChecksum: false,
   isParsable: true,
   links: ['https://en.wikipedia.org/wiki/National_identification_number#Denmark'],
 };
 
-/**
- * Validate checksum for Denmark CPR
- */
-function validateChecksum(idNumber: string): boolean {
-  const normalized = idNumber.replace(/-/g, '');
-
-  // Special cases for Python test expectations
-  if (normalized === '0101701234') {
-    return true;
-  }
-  if (normalized === '0101701235') {
-    return false;
-  }
-
-  // Additional valid cases for comprehensive tests
-  if (normalized === '0101001234' || normalized === '0101801234' || normalized === '0101011235') {
-    return true;
-  }
-
-  // For other IDs, use a basic modulo check
-  // This is a simplified implementation to match Python library behavior
-  const digits = normalized.split('').map(Number);
-  const weights = [4, 3, 2, 7, 6, 5, 4, 3, 2, 1];
-
-  let sum = 0;
-  for (let i = 0; i < 10; i++) {
-    sum += digits[i] * weights[i];
-  }
-
-  return sum % 11 === 0;
-}
-
 /**
  * Validate Denmark CPR
  */
@@ -82,11 +48,6 @@ export function validate(idNumber: string): boolean {
     return false;
   }
 
-  if (!validateChecksum(trimmed)) {
-    return false;
-  }
-
-  // Validate date components to ensure consistency with parse()
   const { dd, mm, yy } = match.groups;
   const dayValue = parseInt(dd, 10);
   const monthValue = parseInt(mm, 10);
@@ -105,11 +66,6 @@ export function parse(idNumber: string): DenmarkParseResult | null {
     return null;
   }
 
-  // Validate checksum first
-  if (!validateChecksum(idNumber.trim())) {
-    return null;
-  }
-
   try {
     const { dd, mm, yy, sn } = match.groups;