Enhance ExtSimulation with getters for new data in ExtSimAdapterData
#392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
I'm not sure if we have an aligned strategy on testing within simonaAPI. What do you think, should there be some tests on this or on the ExtSimulation class at all?
Member
Author
|
In my opinion, we don't have to test these getters. But I can add some tests if necessary. But I don't know, if we should keep this data in this class, since we only need it for setting up the external simulation. Maybe we could split it into two classes. |
danielfeismann
deleted the
ms/#391-enhance-ExtSimulation-with-getter-for-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #391