api/api-keys: replace .find() with .some() in allowedServices

wukko · wukko · commit 8feaf5c63683 · 2025-06-26T22:32:39.000+06:00
&amp; also a little refactor
diff --git a/api/src/security/api-keys.js b/api/src/security/api-keys.js
@@ -80,10 +80,10 @@ const validateKeys = (input) => {
         }
 
         if (details.allowedServices) {
-            const isArray = Array.isArray(details.allowedServices);
-
-            if (isArray) {
-                const invalid_services = details.allowedServices.find(service => !env.allServices.has(service));
+            if (Array.isArray(details.allowedServices)) {
+                const invalid_services = details.allowedServices.some(
+                    service => !env.allServices.has(service)
+                );
                 if (invalid_services) {
                     throw "`allowedServices` in details contains an invalid service";
                 }

Original file line number	Diff line number	Diff line change
`@@ -80,10 +80,10 @@ const validateKeys = (input) => {`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`if (details.allowedServices) {`
`83`		`- const isArray = Array.isArray(details.allowedServices);`
`84`		`-`
`85`		`- if (isArray) {`
`86`		`- const invalid_services = details.allowedServices.find(service => !env.allServices.has(service));`
	`83`	`+ if (Array.isArray(details.allowedServices)) {`
	`84`	`+ const invalid_services = details.allowedServices.some(`
	`85`	`+ service => !env.allServices.has(service)`
	`86`	`+ );`
`87`	`87`	`if (invalid_services) {`
`88`	`88`	throw "`allowedServices` in details contains an invalid service";
`89`	`89`	`}`