increase code coverage

Author: beer-1

x/opchild/keeper/genesis_test.go

@@ -26,7 +26,32 @@ func Test_GenesisImportExport(t *testing.T) {
 	_, err = input.OPChildKeeper.IncreaseNextL1Sequence(ctx) // 3
 	require.NoError(t, err)
 
-	err = input.OPChildKeeper.DenomPairs.Set(ctx, "foo", "bar")
+	// set denom pairs
+	l2DenomFoo := ophosttypes.L2Denom(1, "foo")
+	l2DenomBar := ophosttypes.L2Denom(1, "bar")
+	err = input.OPChildKeeper.DenomPairs.Set(ctx, l2DenomFoo, "foo")
+	require.NoError(t, err)
+	err = input.OPChildKeeper.DenomPairs.Set(ctx, l2DenomBar, "bar")
+	require.NoError(t, err)
+
+	// set migration info
+	err = input.OPChildKeeper.SetMigrationInfo(ctx, types.MigrationInfo{
+		Denom:        l2DenomFoo,
+		IbcChannelId: "channel-0",
+		IbcPortId:    "transfer",
+	})
+	require.NoError(t, err)
+	err = input.OPChildKeeper.SetMigrationInfo(ctx, types.MigrationInfo{
+		Denom:        l2DenomBar,
+		IbcChannelId: "channel-1",
+		IbcPortId:    "transfer",
+	})
+	require.NoError(t, err)
+
+	// set ibc to l2 denom map
+	err = input.OPChildKeeper.SetIBCToL2DenomMap(ctx, "ibc/foo", l2DenomFoo)
+	require.NoError(t, err)
+	err = input.OPChildKeeper.SetIBCToL2DenomMap(ctx, "ibc/bar", l2DenomBar)
 	require.NoError(t, err)
 
 	genState := input.OPChildKeeper.ExportGenesis(ctx)
@@ -49,6 +74,18 @@ func Test_GenesisImportExport(t *testing.T) {
 			Metadata:              []byte("metadata"),
 		},
 	}
+	genState.MigrationInfos = []types.MigrationInfo{
+		{
+			Denom:        l2DenomFoo,
+			IbcChannelId: "channel-0",
+			IbcPortId:    "transfer",
+		},
+		{
+			Denom:        l2DenomBar,
+			IbcChannelId: "channel-1",
+			IbcPortId:    "transfer",
+		},
+	}
 
 	input.OPChildKeeper.InitGenesis(ctx, genState)
 	genState_ := input.OPChildKeeper.ExportGenesis(ctx)

x/opchild/keeper/migration_test.go

@@ -395,11 +395,15 @@ func Test_MigrateToken_Success(t *testing.T) {
 	input.Faucet.Fund(ctx, sender, sdk.NewCoins(amount)...)
 
 	// Test token migration
-	ibcCoin, err := input.OPChildKeeper.MigrateToken(ctx, migrationInfo, sender, amount)
+	_, err = ms.MigrateToken(ctx, &opchildtypes.MsgMigrateToken{
+		Sender: sender.String(),
+		Amount: amount,
+	})
 	require.NoError(t, err)
 
 	// Verify the IBC coin was created correctly
 	expectedIBCDenom := transfertypes.GetTransferCoin(migrationInfo.IbcPortId, migrationInfo.IbcChannelId, "test1", amount.Amount)
+	ibcCoin := input.BankKeeper.GetBalance(ctx, sender, expectedIBCDenom.Denom)
 	require.Equal(t, expectedIBCDenom, ibcCoin)
 
 	// Verify sender balance is now 0 for the original token
@@ -437,22 +441,28 @@ func Test_MigrateToken_InvalidAmount(t *testing.T) {
 
 	// Test with zero amount
 	zeroAmount := sdk.NewCoin("test1", math.NewInt(0))
-	_, err = input.OPChildKeeper.MigrateToken(ctx, migrationInfo, addrs[0], zeroAmount)
+	_, err = ms.MigrateToken(ctx, &opchildtypes.MsgMigrateToken{
+		Sender: addrs[0].String(),
+		Amount: zeroAmount,
+	})
 	require.Error(t, err)
-	require.Contains(t, err.Error(), "amount is not positive")
+	require.Contains(t, err.Error(), "invalid amount")
 
 	// Test with negative amount - create coin directly to avoid panic
 	negativeAmount := sdk.Coin{
 		Denom:  "test1",
 		Amount: math.NewInt(-100),
 	}
-	_, err = input.OPChildKeeper.MigrateToken(ctx, migrationInfo, addrs[0], negativeAmount)
+	_, err = ms.MigrateToken(ctx, &opchildtypes.MsgMigrateToken{
+		Sender: addrs[0].String(),
+		Amount: negativeAmount,
+	})
 	require.Error(t, err)
-	require.Contains(t, err.Error(), "amount is not positive")
+	require.Contains(t, err.Error(), "invalid amount")
 }
 
-// Test_MigrateToken_DenomMismatch tests token migration with denom mismatch
-func Test_MigrateToken_DenomMismatch(t *testing.T) {
+// Test_MigrateToken_NotFound tests token migration with not found migration info
+func Test_MigrateToken_NotFound(t *testing.T) {
 	ctx, input := createDefaultTestInput(t)
 
 	// Set up denom pair first (L1 token)
@@ -477,9 +487,12 @@ func Test_MigrateToken_DenomMismatch(t *testing.T) {
 
 	// Test with mismatched denom
 	wrongDenomAmount := sdk.NewCoin("test2", math.NewInt(100))
-	_, err = input.OPChildKeeper.MigrateToken(ctx, migrationInfo, addrs[0], wrongDenomAmount)
+	_, err = ms.MigrateToken(ctx, &opchildtypes.MsgMigrateToken{
+		Sender: addrs[0].String(),
+		Amount: wrongDenomAmount,
+	})
 	require.Error(t, err)
-	require.Contains(t, err.Error(), "migration info denom does not match")
+	require.Contains(t, err.Error(), "migration info not found")
 }
 
 // Test_MigrateToken_InsufficientBalance tests token migration with insufficient balance
@@ -508,7 +521,10 @@ func Test_MigrateToken_InsufficientBalance(t *testing.T) {
 
 	// Test with amount larger than balance
 	largeAmount := sdk.NewCoin("test1", math.NewInt(1000))
-	_, err = input.OPChildKeeper.MigrateToken(ctx, migrationInfo, addrs[0], largeAmount)
+	_, err = ms.MigrateToken(ctx, &opchildtypes.MsgMigrateToken{
+		Sender: addrs[0].String(),
+		Amount: largeAmount,
+	})
 	require.Error(t, err)
 	require.Contains(t, err.Error(), "insufficient funds")
 }

x/opchild/keeper/querier_test.go

@@ -11,6 +11,8 @@ import (
 	testutilsims "github.com/cosmos/cosmos-sdk/testutil/sims"
 	sdk "github.com/cosmos/cosmos-sdk/types"
 
+	transfertypes "github.com/cosmos/ibc-go/v8/modules/apps/transfer/types"
+
 	"github.com/initia-labs/OPinit/x/opchild/keeper"
 	"github.com/initia-labs/OPinit/x/opchild/types"
 	ophosttypes "github.com/initia-labs/OPinit/x/ophost/types"
@@ -139,3 +141,39 @@ func Test_QueryBaseDenom(t *testing.T) {
 
 	require.Equal(t, types.QueryBaseDenomResponse{BaseDenom: "base_denom"}, *res)
 }
+
+func Test_QueryMigrationInfo(t *testing.T) {
+	ctx, input := createDefaultTestInput(t)
+	q := keeper.NewQuerier(&input.OPChildKeeper)
+
+	denom := "l2/denom"
+	port := "transfer"
+	channel := "channel-0"
+	migrationInfo := types.MigrationInfo{
+		Denom:        denom,
+		IbcChannelId: channel,
+		IbcPortId:    port,
+	}
+
+	_, err := q.MigrationInfo(ctx, &types.QueryMigrationInfoRequest{Denom: denom})
+	require.Error(t, err) // migration info not found
+
+	// register migration info
+	require.NoError(t, input.OPChildKeeper.SetMigrationInfo(ctx, migrationInfo))
+
+	_, err = q.MigrationInfo(ctx, &types.QueryMigrationInfoRequest{Denom: denom})
+	require.Error(t, err) // base denom not found
+
+	// set base denom
+	require.NoError(t, input.OPChildKeeper.DenomPairs.Set(ctx, denom, "test1"))
+
+	res, err := q.MigrationInfo(ctx, &types.QueryMigrationInfoRequest{Denom: denom})
+	require.NoError(t, err)
+
+	ibcDenom := transfertypes.ParseDenomTrace(transfertypes.GetPrefixedDenom(migrationInfo.IbcPortId, migrationInfo.IbcChannelId, "test1")).IBCDenom()
+	require.Equal(t, types.QueryMigrationInfoResponse{MigrationInfo: types.MigrationInfo{
+		Denom:        denom,
+		IbcChannelId: channel,
+		IbcPortId:    port,
+	}, IbcDenom: ibcDenom}, *res)
+}

x/ophost/keeper/querier_test.go

@@ -296,3 +296,20 @@ func Test_QueryBatchInfos(t *testing.T) {
 	}, res.BatchInfos,
 	)
 }
+
+func Test_QueryMigrationInfo(t *testing.T) {
+	ctx, input := createDefaultTestInput(t)
+	q := keeper.NewQuerier(input.OPHostKeeper)
+	_, err := q.MigrationInfo(ctx, &types.QueryMigrationInfoRequest{BridgeId: 1, L1Denom: "l1denom"})
+	require.Error(t, err)
+
+	migrationInfo := types.MigrationInfo{
+		BridgeId: 1,
+		L1Denom:  "l1denom",
+	}
+	require.NoError(t, input.OPHostKeeper.SetMigrationInfo(ctx, migrationInfo))
+
+	res, err := q.MigrationInfo(ctx, &types.QueryMigrationInfoRequest{BridgeId: 1, L1Denom: "l1denom"})
+	require.NoError(t, err)
+	require.Equal(t, migrationInfo, res.MigrationInfo)
+}