Skip to content

Commit 92d8583

Browse files
committed
fix: wait for medium e2e to finish and pass
Signed-off-by: Charlie Doern <[email protected]>
1 parent aacd5b4 commit 92d8583

File tree

2 files changed

+31
-2
lines changed

2 files changed

+31
-2
lines changed

.github/mergify.yml

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,25 @@ pull_request_rules:
2323
- and:
2424
- -files~=^\.github/(actions|workflows)/.*\.ya?ml$
2525
- -files~=^\.github/workflows/actionlint\.
26-
26+
# medium e2e workflow
27+
- or:
28+
- and:
29+
# note this should match the triggering criteria in 'e2e-nvidia-l4-x1.yml'
30+
- check-success~=e2e-medium-workflow-complete
31+
- or:
32+
- files~=\.py$
33+
- files=pyproject.toml
34+
- files~=^requirements.*\.txt$
35+
- files=tox.ini
36+
- files~=^scripts/[^/]+\.sh$
37+
- files=.github/workflows/lint.yml
38+
- and:
39+
- -files~=\.py$
40+
- -files=pyproject.toml
41+
- -files~=^requirements.*\.txt$
42+
- -files=tox.ini
43+
- -files~=^scripts/[^/]+\.sh$
44+
- -files=.github/workflows/lint.yml
2745
# code lint workflow
2846
- or:
2947
- and:

.github/workflows/e2e-nvidia-l40s-x4-sdk.yml

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,4 +324,15 @@ jobs:
324324
if: steps.phase-2-upload-s3.outcome == 'failure'
325325
run: |
326326
echo "::warning::Failed to upload Phase 2 loss graph to S3. This won't block the workflow, but you may want to investigate."
327-
echo "Loss graph upload failed" >> "${GITHUB_STEP_SUMMARY}"
327+
echo "Loss graph upload failed" >> "${GITHUB_STEP_SUMMARY}"
328+
329+
e2e-medium-workflow-complete:
330+
# we don't want to block PRs on failed EC2 cleanup
331+
# so not requiring "stop-medium-ec2-runner" as well
332+
permissions:
333+
checks: read
334+
uses: ./.github/workflows/status-checks.yml
335+
with:
336+
job_ids: >- # Space-separated job ids to wait on for status checks
337+
start-large-ec2-runner
338+
e2e-medium-test

0 commit comments

Comments
 (0)