Set large GRF in cmake #445
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandschulz
commented
Jun 26, 2025
|
|
||
| CMake will check that DPC++ compiler is available in the system, | ||
| and it will download the MKL library if it cannot find it. | ||
| To get better performance result we require the following combinations of the environment variables flags to provide better performance hints for generating optimised code. For ahead of time (AOT) compilation, the following options have to be set during compilation and for Just in time (JIT) Compilation when running |
There was a problem hiding this comment.
They are still needed for spir64 target. But because we don't describe that option I don't think this needs to be mentioned.
rolandschulz
commented
Jun 26, 2025
| export SYCL_PROGRAM_COMPILE_OPTIONS="-ze-opt-large-register-file" | ||
| export IGC_VISAOptions="-perfmodel" | ||
| export IGC_VectorAliasBBThreshold=10000 | ||
| export IGC_ExtraOCLOptions="-cl-intel-256-GRF-per-thread" |
There was a problem hiding this comment.
This was anyhow redundant for -ze-opt-large-register-file (in the JIT case)
rolandschulz
commented
Jun 26, 2025
| To get better performance result we require the following combinations of the environment variables flags to provide better performance hints for generating optimised code. For ahead of time (AOT) compilation, the following options have to be set during compilation and for Just in time (JIT) Compilation when running | ||
|
|
||
| ``` | ||
| export SYCL_PROGRAM_COMPILE_OPTIONS="-ze-opt-large-register-file" |
There was a problem hiding this comment.
This is now set by this PR for AOT. Before this was only used for JIT (in which case this env-variable is used).
rolandschulz
commented
Jun 26, 2025
|
|
||
| ``` | ||
| export SYCL_PROGRAM_COMPILE_OPTIONS="-ze-opt-large-register-file" | ||
| export IGC_VISAOptions="-perfmodel" |
There was a problem hiding this comment.
I don't think this is needed for anything. Anyone remember why this is here?
rolandschulz
commented
Jun 26, 2025
| ``` | ||
| export SYCL_PROGRAM_COMPILE_OPTIONS="-ze-opt-large-register-file" | ||
| export IGC_VISAOptions="-perfmodel" | ||
| export IGC_VectorAliasBBThreshold=10000 |
There was a problem hiding this comment.
This was already added automatically before.
jiyang1011
approved these changes
Aug 11, 2025
tdeng5
approved these changes
Sep 5, 2025
|
we decided it's better to set it from the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #427