Skip to content

Conversation

@Samk13
Copy link
Member

@Samk13 Samk13 commented Oct 9, 2025

❤️ Thank you for your contribution!

Description

Screen.Recording.2025-10-09.at.15.47.13.mov

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

* long file names breaks records landing page, this commit fix it.
* closes inveniosoftware#3195
@Samk13 Samk13 moved this to 👀 In review in vNext Oct 9, 2025
@Samk13 Samk13 added this to vNext Oct 9, 2025
@Samk13 Samk13 added the backport-v13 These changes need to be backported to the `maint-v13.x` branch label Oct 9, 2025
Copy link
Contributor

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, at first I thought this was a regression of #2158, but actually that one only worked with filenames that had spaces in them allowing for default word breaks.

The recommended approach has been to create a utility class and then apply that class to the elements. See comments. @kpsherva can also validate if this is the appropriate way.

Comment on lines +563 to +567
#preview-file-title,
td.ten.wide a {
word-break: break-word;
overflow-wrap: break-word;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utility classes is favored if I remember correctly:

Suggested change
#preview-file-title,
td.ten.wide a {
word-break: break-word;
overflow-wrap: break-word;
}
.overflow-break-and-wrap-word { // or another catchy name
word-break: break-word;
overflow-wrap: break-word;
}

Then place it on <td class="ten wide overflow-break-and-wrap-word"> and the #preview-file-title element.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fenekku, I think the change fixes the issue (affects Zenodo too).
Since this file already includes similar one-off overrides, keeping the rule here makes sense and keeps it scoped to the affected elements.
If there’s interest in turning it into a utility class later, that’s fine but it’s not really needed for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v13 These changes need to be backported to the `maint-v13.x` branch

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

UI: Long file names break layout on landing page UI

2 participants