[🐛] Auth - Cannot override async storage methods

[AngeloMateus]

Issue

Hey guys

I'm currently transitioning from @firebase/auth to @react-native-firebase/auth the issue is - Overriding async storage methods (getItem(), setItem()) no longer works
I've tried the following:

import { initializeApp } from "@react-native-firebase/app";
import { initializeAuth } from "@react-native-firebase/auth";
import { getReactNativePersistence } from "firebase/auth";

  const app = await initializeApp(firebaseConfig);
  const auth = initializeAuth(app, {
    persistence: getReactNativePersistence(Overriding class)
  });

Is there any way to override these methods?
Using @react-native-firebase 23.0.1

[mikehardy]

I've noticed in our "Other" e2e test suite that our warning message indicating there is no react-native persistence set is currently being emitted - indicating it isn't set at all - yet we are definitely setting it and I specifically remember successfully testing analytics (where persistence is used to store the identifier for an installation across instances)

So this may be a more general issue - I only looked at it in passing I did not attempt to fix it (yet)

Running the other e2e tests focused in on either auth (possibly any of the tests) or analytics (possibly just session id tests) should expose things in general. Attempting to provide an overridden react native persistence that meets the contract should be possible as well as a further test

[mikehardy]

@AngeloMateus I think for purposes of using native (android or ios platform, not other/web platform) in react-native-firebase it may be an expectations mis-match though. The native SDKs for firebase manage their own persistence in iOS keychain or Android user preferences stored app-local and there is no need nor ability to actually set the persistence there as it is all handled by the native SDKs.

Web / firebase-js-sdk needs it as otherwise there's no place to store things that they may expect to exist and generally rely on given the diversity of pure-JS platforms.

So I believe on the native platforms it's simply a no-op and your need / desire to use that API should go away - if you want the identifiers that were going in there for use somewhere else in your app, you should store them as a separate specific bit of functionality in your app vs peeking in on them as they pass through as a side effect

react-native-firebase/packages/auth/lib/modular/index.js

Lines 226 to 234 in db0d036

	/**
	* Changes the type of persistence on the Auth instance for the currently saved Auth session and applies this type of persistence for future sign-in requests, including sign-in with redirect requests.
	* @param {Auth} auth - The Auth instance.
	* @param {Persistence} persistence - The persistence type.
	* @returns {Promise<void>}
	*/
	export async function setPersistence(auth, persistence) {
	throw new Error('setPersistence is unsupported by the native Firebase SDKs');
	}

And you can see it is ignored here on native platforms, deps are simply discarded as they have no purpose on native, perhaps if they are supplied we could warn on native - not sure that's the best course or not:

react-native-firebase/packages/auth/lib/modular/index.js

Lines 60 to 71 in db0d036

	/**
	* This function allows more control over the Auth instance than getAuth().
	* @param {FirebaseApp} app - The Firebase app instance.
	* @param {any} [deps] - Optional. Dependencies for the Auth instance.
	* @returns {Auth}
	*/
	export function initializeAuth(app, deps) {
	if (app) {
	return getApp(app.name).auth();
	}
	return getApp().auth();
	}

[Angelo-KittyCard]

Understood, we were overriding the persistence class previously to ensure certain checks were made prior to Firebase retrieving auth tokens from storage. I guess we'll find a workaround. Thanks for your help.