Redundant visuals in KinematicElement

[christian-rauch]

The KinematicElement stores visuals in two ways.

It (1) stores a path to the resource and a shape pointer directly as members:

exotica/exotica_core/include/exotica_core/kinematic_element.h

Lines 124 to 125 in 9e1da60

	shapes::ShapeConstPtr shape = nullptr;
	std::string shape_resource_path = "";

but is (2) also stores an array of VisualElement:

exotica/exotica_core/include/exotica_core/kinematic_element.h

Line 129 in 9e1da60

std::vector<VisualElement> visual;

This appears to be redundant and confusing because it is not documented, if they are used in different ways. Can the members (shape and shape_resource_path) be removed?

In my scenario, the members are empty and the VisualElement actually contains the mesh reference.

[wxmerkt]

These are from different times and serve different purpose:

• The shape is the traditionally loaded collision shape, which gets used in the CollisionScene
• The shape_resource_path is used when a mesh is loaded via AddEnvironmentElement and needs to be used published on the CollisionShapes topic because it is not part of the robot kinematics
• The VisualElement is for the new visualiser, i.e., MeshCat

I agree documentation and some clean-up once the new visualisers are ready is in order.

[christian-rauch]

I see that shape_resource_path is used for the visualization_msgs/Marker. Is the shape then only set, when a collision scene if created?

[wxmerkt]

From what I recall, yes. The shape is technically the collision shape.