Skip to content

Commit 6a0f333

Browse files
authored
Merge pull request #45 from j0k3r/fix/update-fixer-rules
Update fixer rules
2 parents 49ce423 + 2dce287 commit 6a0f333

File tree

4 files changed

+585
-582
lines changed

4 files changed

+585
-582
lines changed

.php_cs

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,22 +4,27 @@ return PhpCsFixer\Config::create()
44
->setUsingCache(true)
55
->setRiskyAllowed(true)
66
->setRules([
7-
'concat_space' => [
8-
'spacing' => 'one',
9-
],
7+
'@Symfony' => true,
8+
'@Symfony:risky' => true,
9+
'array_syntax' => ['syntax' => 'short'],
10+
'combine_consecutive_unsets' => true,
11+
'heredoc_to_nowdoc' => true,
12+
'no_extra_consecutive_blank_lines' => ['break', 'continue', 'extra', 'return', 'throw', 'use', 'parenthesis_brace_block', 'square_brace_block', 'curly_brace_block'],
13+
'no_unreachable_default_argument_value' => true,
14+
'no_useless_else' => true,
15+
'no_useless_return' => true,
16+
'ordered_class_elements' => true,
1017
'ordered_imports' => true,
18+
'php_unit_strict' => false,
1119
'phpdoc_order' => true,
20+
// 'psr4' => true,
1221
'strict_comparison' => true,
1322
'strict_param' => true,
14-
'array_syntax' => [
15-
'syntax' => 'long',
16-
],
23+
'concat_space' => ['spacing' => 'one'],
1724
])
1825
->setFinder(
1926
PhpCsFixer\Finder::create()
20-
->exclude([
21-
'vendor',
22-
])
27+
->exclude(['vendor'])
2328
->in(__DIR__)
2429
)
2530
;

src/JSLikeHTMLElement.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class JSLikeHTMLElement extends \DOMElement
4545
*/
4646
public function __set($name, $value)
4747
{
48-
if ($name !== 'innerHTML') {
48+
if ('innerHTML' !== $name) {
4949
$trace = debug_backtrace();
5050
trigger_error('Undefined property via __set(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_NOTICE);
5151

@@ -109,7 +109,7 @@ public function __set($name, $value)
109109
*/
110110
public function __get($name)
111111
{
112-
if ($name === 'innerHTML') {
112+
if ('innerHTML' === $name) {
113113
$inner = '';
114114

115115
foreach ($this->childNodes as $child) {
@@ -121,8 +121,6 @@ public function __get($name)
121121

122122
$trace = debug_backtrace();
123123
trigger_error('Undefined property via __get(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_NOTICE);
124-
125-
return;
126124
}
127125

128126
public function __toString()

0 commit comments

Comments
 (0)