Merge pull request #3 from j0k3r/phpunit-travis

Improve Travis

Author: j0k3r

.gitignore

@@ -1 +1,3 @@
 vendor/
+coverage/
+composer.lock

.scrutinizer.yml

@@ -0,0 +1,3 @@
+tools:
+    external_code_coverage:
+        timeout: 600

.travis.yml

@@ -4,10 +4,29 @@ php:
     - 5.4
     - 5.5
     - 5.6
+    - nightly
+    - hhvm-nightly
 
-before_script:
+# run build against nightly but allow them to fail
+matrix:
+    fast_finish: true
+    allow_failures:
+        - php: nightly
+        - php: hhvm-nightly
+
+# faster builds on new travis setup not using sudo
+sudo: false
+
+install:
     - composer self-update
+
+before_script:
     - composer install --prefer-dist --no-interaction
 
 script:
-    - phpunit --coverage-text
+    - phpunit --coverage-clover=coverage.clover
+
+after_script:
+    - |
+        wget https://scrutinizer-ci.com/ocular.phar
+        php ocular.phar code-coverage:upload --format=php-clover coverage.clover

README.md

@@ -1,6 +1,7 @@
 # Readability
 
 [![Build Status](https://travis-ci.org/j0k3r/php-readability.svg?branch=master)](https://travis-ci.org/j0k3r/php-readability)
+[![Code Coverage](https://scrutinizer-ci.com/g/j0k3r/php-readability/badges/coverage.png?b=master)](https://scrutinizer-ci.com/g/j0k3r/php-readability/?branch=master)
 
 This is an extract of the Readability class from the [full-text-rss](https://github.com/Dither/full-text-rss) fork. It kind be defined as a better version of the original [php-readability](http://code.fivefilters.org/php-readability).
 

phpunit.xml.dist

@@ -19,11 +19,14 @@
 
     <filter>
         <whitelist>
-            <directory>./src/TubeLink/</directory>
+            <directory>./src/</directory>
             <exclude>
                 <directory>./tests</directory>
             </exclude>
         </whitelist>
     </filter>
 
+    <logging>
+        <log type="coverage-html" target="coverage" title="FullText" charset="UTF-8" yui="true" highlight="true" lowUpperBound="35" highLowerBound="70"/>
+    </logging>
 </phpunit>

src/JSLikeHTMLElement.php

@@ -3,7 +3,7 @@
 namespace Readability;
 
 /**
- * JavaScript-like HTML DOM Element
+ * JavaScript-like HTML DOM Element.
  *
  * This class extends PHP's DOMElement to allow
  * users to get and set the innerHTML property of
@@ -31,12 +31,14 @@
  *     echo $doc->saveXML();
  *
  * @author Keyvan Minoukadeh - http://www.keyvan.net - [email protected]
+ *
  * @see http://fivefilters.org (the project this was written for)
  */
 class JSLikeHTMLElement extends \DOMElement
 {
     /**
-     * Used for setting innerHTML like it's done in JavaScript:
+     * Used for setting innerHTML like it's done in JavaScript:.
+     *
      * @code
      * $div->innerHTML = '<h2>Chapter 2</h2><p>The story begins...</p>';
      * @endcode
@@ -45,7 +47,7 @@ public function __set($name, $value)
     {
         if ($name == 'innerHTML') {
             // first, empty the element
-            for ($x=$this->childNodes->length-1; $x>=0; $x--) {
+            for ($x = $this->childNodes->length - 1; $x >= 0; $x--) {
                 $this->removeChild($this->childNodes->item($x));
             }
             // $value holds our new inner HTML
@@ -86,7 +88,8 @@ public function __set($name, $value)
     }
 
     /**
-     * Used for getting innerHTML like it's done in JavaScript:
+     * Used for getting innerHTML like it's done in JavaScript:.
+     *
      * @code
      * $string = $div->innerHTML;
      * @endcode
@@ -105,7 +108,7 @@ public function __get($name)
         $trace = debug_backtrace();
         trigger_error('Undefined property via __get(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_NOTICE);
 
-        return null;
+        return;
     }
 
     public function __toString()