Fix lint and test configurations

Author: hharshhsaini

cmd/jaeger/internal/extension/jaegermcp/internal/skills/loader.go

@@ -1,3 +1,6 @@
+// Copyright (c) 2026 The Jaeger Authors.
+// SPDX-License-Identifier: Apache-2.0
+
 package skills
 
 import (

cmd/jaeger/internal/extension/jaegermcp/internal/skills/loader_test.go

@@ -1,3 +1,6 @@
+// Copyright (c) 2026 The Jaeger Authors.
+// SPDX-License-Identifier: Apache-2.0
+
 package skills
 
 import (
@@ -6,6 +9,7 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 	"go.uber.org/zap"
 )
 
@@ -27,8 +31,8 @@ system_prompt: "You are a test."
 version: "1.0"
 author: "test"
 `
-		err := os.WriteFile(filepath.Join(tempDir, "test.yaml"), []byte(skillData), 0644)
-		assert.NoError(t, err)
+		err := os.WriteFile(filepath.Join(tempDir, "test.yaml"), []byte(skillData), 0o644)
+		require.NoError(t, err)
 
 		skills := LoadSkills(tempDir, logger)
 		assert.Len(t, skills, 1)
@@ -42,8 +46,8 @@ author: "test"
 description: "A test skill"
 system_prompt: "You are a test."
 `
-		err := os.WriteFile(filepath.Join(tempDir, "missing_name.yaml"), []byte(skillData), 0644)
-		assert.NoError(t, err)
+		err := os.WriteFile(filepath.Join(tempDir, "missing_name.yaml"), []byte(skillData), 0o644)
+		require.NoError(t, err)
 
 		skills := LoadSkills(tempDir, logger)
 		assert.Empty(t, skills)
@@ -55,8 +59,8 @@ system_prompt: "You are a test."
 name: test-skill
 description: "A test skill"
 `
-		err := os.WriteFile(filepath.Join(tempDir, "missing_prompt.yaml"), []byte(skillData), 0644)
-		assert.NoError(t, err)
+		err := os.WriteFile(filepath.Join(tempDir, "missing_prompt.yaml"), []byte(skillData), 0o644)
+		require.NoError(t, err)
 
 		skills := LoadSkills(tempDir, logger)
 		assert.Empty(t, skills)

cmd/jaeger/internal/extension/jaegermcp/internal/skills/package_test.go

@@ -0,0 +1,14 @@
+// Copyright (c) 2024 The Jaeger Authors.
+// SPDX-License-Identifier: Apache-2.0
+
+package skills
+
+import (
+	"testing"
+
+	"github.com/jaegertracing/jaeger/internal/testutils"
+)
+
+func TestMain(m *testing.M) {
+	testutils.VerifyGoLeaks(m)
+}

cmd/jaeger/internal/extension/jaegermcp/internal/skills/registry.go

@@ -1,3 +1,6 @@
+// Copyright (c) 2026 The Jaeger Authors.
+// SPDX-License-Identifier: Apache-2.0
+
 package skills
 
 import (
@@ -21,7 +24,7 @@ func NewRegistry() *Registry {
 func (r *Registry) Register(skill Skill) {
 	r.mu.Lock()
 	defer r.mu.Unlock()
-	
+
 	if skill.Name == "" {
 		return
 	}
@@ -32,7 +35,7 @@ func (r *Registry) Register(skill Skill) {
 func (r *Registry) Get(name string) (Skill, bool) {
 	r.mu.RLock()
 	defer r.mu.RUnlock()
-	
+
 	skill, ok := r.skills[name]
 	return skill, ok
 }
@@ -41,7 +44,7 @@ func (r *Registry) Get(name string) (Skill, bool) {
 func (r *Registry) List() []Skill {
 	r.mu.RLock()
 	defer r.mu.RUnlock()
-	
+
 	var skills []Skill
 	for _, skill := range r.skills {
 		skills = append(skills, skill)

cmd/jaeger/internal/extension/jaegermcp/internal/skills/registry_test.go

@@ -1,3 +1,6 @@
+// Copyright (c) 2026 The Jaeger Authors.
+// SPDX-License-Identifier: Apache-2.0
+
 package skills
 
 import (
@@ -8,30 +11,30 @@ import (
 
 func TestRegistryRegisterAndGet(t *testing.T) {
 	registry := NewRegistry()
-	
+
 	skill := Skill{
 		Name:         "test-skill",
 		Description:  "A test skill",
 		SystemPrompt: "You are a test.",
 	}
-	
+
 	registry.Register(skill)
-	
+
 	retrievedSkill, ok := registry.Get("test-skill")
 	assert.True(t, ok)
 	assert.Equal(t, skill, retrievedSkill)
 }
 
 func TestRegistryGetMissing(t *testing.T) {
 	registry := NewRegistry()
-	
+
 	_, ok := registry.Get("missing-skill")
 	assert.False(t, ok)
 }
 
 func TestRegistryList(t *testing.T) {
 	registry := NewRegistry()
-	
+
 	skill1 := Skill{
 		Name:         "test-skill-1",
 		Description:  "A test skill 1",
@@ -42,21 +45,24 @@ func TestRegistryList(t *testing.T) {
 		Description:  "A test skill 2",
 		SystemPrompt: "You are a test 2.",
 	}
-	
+
 	registry.Register(skill1)
 	registry.Register(skill2)
-	
+
 	skills := registry.List()
 	assert.Len(t, skills, 2)
-	
+
 	// Registry map iteration order is not guaranteed, so just check contents
 	found1 := false
 	found2 := false
 	for _, s := range skills {
-		if s.Name == "test-skill-1" {
+		switch s.Name {
+		case "test-skill-1":
 			found1 = true
-		} else if s.Name == "test-skill-2" {
+		case "test-skill-2":
 			found2 = true
+		default:
+			// Ignore other skills
 		}
 	}
 	assert.True(t, found1)
@@ -65,14 +71,14 @@ func TestRegistryList(t *testing.T) {
 
 func TestRegistryRegisterEmptyName(t *testing.T) {
 	registry := NewRegistry()
-	
+
 	skill := Skill{
 		Description:  "A test skill",
 		SystemPrompt: "You are a test.",
 	}
-	
+
 	registry.Register(skill)
-	
+
 	skills := registry.List()
 	assert.Empty(t, skills)
 }

cmd/jaeger/internal/extension/jaegermcp/internal/skills/skills.go

@@ -1,3 +1,6 @@
+// Copyright (c) 2026 The Jaeger Authors.
+// SPDX-License-Identifier: Apache-2.0
+
 package skills
 
 // SkillTool represents a tool that a skill can use

go.mod

@@ -105,6 +105,7 @@ require (
 	golang.org/x/sys v0.41.0
 	google.golang.org/grpc v1.79.1
 	google.golang.org/protobuf v1.36.11
+	gopkg.in/yaml.v3 v3.0.1
 )
 
 require (
@@ -151,7 +152,6 @@ require (
 	golang.org/x/oauth2 v0.34.0 // indirect
 	golang.org/x/time v0.14.0 // indirect
 	google.golang.org/api v0.258.0 // indirect
-	gopkg.in/yaml.v3 v3.0.1 // indirect
 	k8s.io/apimachinery v0.34.3 // indirect
 	k8s.io/client-go v0.34.3 // indirect
 	k8s.io/klog/v2 v2.130.1 // indirect