fix: use $(SUFFIX) in version-check binary path for debug builds (#8148)

The version-check step in `build-jaeger` hardcoded the binary name
without `$(SUFFIX)`, so when invoked via
`_build-platform-binaries-debug` (which sets `DEBUG_BINARY=1` →
`SUFFIX=-debug`), the check either failed with "binary not found" or
silently validated the release binary instead of the debug one.

- **`scripts/makefiles/BuildBinaries.mk`**: Replace
`./cmd/jaeger/jaeger-$(GOOS)-$(GOARCH)` with
`./cmd/jaeger/jaeger$(SUFFIX)-$(GOOS)-$(GOARCH)` in both version-check
invocations — no-op for release builds (`SUFFIX` is empty), correct for
debug builds (`SUFFIX=-debug`).

<!-- START COPILOT CODING AGENT TIPS -->
---

✨ Let Copilot coding agent [set things up for
you](https://github.com/jaegertracing/jaeger/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot)
— coding agent works faster and does higher quality work when set up for
your repo.

---------

Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yurishkuro <3523016+yurishkuro@users.noreply.github.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: 3 people

scripts/build/build-upload-docker-images.sh

@@ -83,7 +83,7 @@ build_image() {
   bash scripts/build/build-upload-a-docker-image.sh "${FLAGS[@]}" "${base_flags[@]}" -c "$component" -d "$dir" -p "${platforms}" "${target_flags[@]}"
 
   if [[ "$build_debug" == "true" ]] && [[ "${add_debugger}" == "Y" ]]; then
-    bash scripts/build/build-upload-a-docker-image.sh "${FLAGS[@]}" "${base_flags[@]}" -c "${component}-debug" -d "$dir" -t debug
+    bash scripts/build/build-upload-a-docker-image.sh "${FLAGS[@]}" "${base_flags[@]}" -c "${component}-debug" -d "$dir" -p "${platforms}" -t debug
   fi
 }
 

scripts/makefiles/BuildBinaries.mk

@@ -85,10 +85,10 @@ build-jaeger: build-ui _build-a-binary-jaeger$(SUFFIX)-$(GOOS)-$(GOARCH)
 	REAL_GOOS=$(shell GOOS= $(GO) env GOOS) ; \
 	REAL_GOARCH=$(shell GOARCH= $(GO) env GOARCH) ; \
 	if [ "$(GOOS)" == "$$REAL_GOOS" ] && [ "$(GOARCH)" == "$$REAL_GOARCH" ]; then \
-		./cmd/jaeger/jaeger-$(GOOS)-$(GOARCH) version 2>/dev/null ; \
+		./cmd/jaeger/jaeger$(SUFFIX)-$(GOOS)-$(GOARCH) version 2>/dev/null ; \
 		echo "" ; \
 		want=$(GIT_CLOSEST_TAG) ; \
-		have=$$(./cmd/jaeger/jaeger-$(GOOS)-$(GOARCH) version 2>/dev/null | jq -r .gitVersion) ; \
+		have=$$(./cmd/jaeger/jaeger$(SUFFIX)-$(GOOS)-$(GOARCH) version 2>/dev/null | jq -r .gitVersion) ; \
 		if [ "$$want" == "$$have" ]; then \
 			echo "☑️ versions match: want=$$want, have=$$have" ; \
 		else \
@@ -157,11 +157,11 @@ ifneq ($(SKIP_DEBUG_BINARIES),1)
 endif
 
 # build binaries that support DEBUG release, for one specific platform GOOS/GOARCH
+# Uses recursive make calls so that DEBUG_BINARY=1 is set at parse time,
+# ensuring SUFFIX=-debug is correctly evaluated in the ifeq conditional at the top.
 .PHONY: _build-platform-binaries-debug
-_build-platform-binaries-debug: DEBUG_BINARY=1
-_build-platform-binaries-debug: \
-	build-jaeger \
-	build-remote-storage
+_build-platform-binaries-debug:
+	$(MAKE) build-jaeger build-remote-storage GOOS=$(GOOS) GOARCH=$(GOARCH) DEBUG_BINARY=1
 
 .PHONY: build-all-platforms
 build-all-platforms: