integration: initialize SearchDepth and Attributes in testGetServices diagnostic query (#9485) - #9518
Open
SHIVANSH-ux-ys wants to merge 1 commit into
Conversation
… diagnostic query (jaegertracing#9485) Signed-off-by: SHIVANSH-ux-ys <singaser78@gmail.com>
SHIVANSH-ux-ys
force-pushed
the
fix-9485-testGetServices-diagnostic-query
branch
from
September 9, 2026 04:07
93103ab to
61dfa5f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9518 +/- ##
==========================================
+ Coverage 97.96% 98.56% +0.60%
==========================================
Files 388 392 +4
Lines 20846 18374 -2472
==========================================
- Hits 20422 18111 -2311
+ Misses 286 263 -23
+ Partials 138 0 -138
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
CI Summary ReportMetrics ComparisonView changed metricsFor label-level diff details, open the CI run and expand the "Compare metrics and generate summary" step logs. metrics_snapshot_kafka_v2 — ⬇️ download diff
Code Coverage✅ Coverage 98.7% (baseline 98.7%) ➡️ View CI run | View publish logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
SearchDepth: 100andAttributes: pcommon.NewMap()ontracestore.TraceQueryParamsintestGetServicesdiagnostic query (internal/storage/integration/integration.go).testGetServicesfrom panicking due to nil pointer dereference on uninitializedAttributeswhen logging unexpected storage services.How was this change tested?
STORAGE=memory go test -v -run TestMemoryStorage ./internal/storage/integration.Checklist
AI Usage in this PR