Skip to content

Commit 6ee0c9e

Browse files
authored
Merge pull request #3206 from hoffie/autobuild-windows-wait-for-jack-install
2 parents 135e944 + aeb7239 commit 6ee0c9e

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

.github/autobuild/windows.ps1

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,10 @@ param(
3939
# Fail early on all errors
4040
$ErrorActionPreference = "Stop"
4141

42+
# Invoke-WebRequest is really slow by default because it renders a progress bar.
43+
# Disabling this, improves vastly performance:
44+
$ProgressPreference = 'SilentlyContinue'
45+
4246
$QtDir = 'C:\Qt'
4347
$ChocoCacheDir = 'C:\ChocoCache'
4448
$DownloadCacheDir = 'C:\AutobuildCache'
@@ -179,7 +183,7 @@ Function Ensure-JACK
179183

180184
$JACKInstallPath = "${DownloadCacheDir}\JACK64.exe"
181185

182-
& $JACKInstallPath $JACKInstallParms
186+
Start-Process -Wait $JACKInstallPath -ArgumentList "$JACKInstallParms"
183187

184188
if ( !$? )
185189
{
@@ -194,7 +198,7 @@ Function Ensure-JACK
194198

195199
$JACKInstallPath = "${DownloadCacheDir}\JACK32.exe"
196200

197-
& $JACKInstallPath $JACKInstallParms
201+
Start-Process -Wait $JACKInstallPath -ArgumentList "$JACKInstallParms"
198202

199203
if ( !$? )
200204
{

windows/deploy_windows.ps1

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ param (
2121
# Fail early on all errors
2222
$ErrorActionPreference = "Stop"
2323

24+
# Invoke-WebRequest is really slow by default because it renders a progress bar.
25+
# Disabling this, improves vastly performance:
26+
$ProgressPreference = 'SilentlyContinue'
27+
2428
# change directory to the directory above (if needed)
2529
Set-Location -Path "$PSScriptRoot\..\"
2630

0 commit comments

Comments
 (0)