Skip to content

Commit ceea99a

Browse files
committed
postmerge fix
1 parent 6ec94b6 commit ceea99a

File tree

6 files changed

+1210
-8
lines changed

6 files changed

+1210
-8
lines changed

CommonData/column.cpp

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -591,7 +591,7 @@ columnType Column::setValues(size_t rows, const std::function<std::string(size_t
591591

592592

593593
dbUpdateValues();
594-
594+
595595
//Now determine what the most logical columntype would be given the current values AND empty values!
596596
if(onlyInts && ints.size() <= thresholdScale && ints.size() > 0)
597597
{
@@ -1017,7 +1017,12 @@ int Column::nonFilteredNumericsCount() const
10171017
return _nonFilteredNumericsCount;
10181018
}
10191019

1020-
stringvec Column::nonFilteredLevels()
1020+
const stringvec & Column::nonFilteredLevels() const
1021+
{
1022+
return _nonFilteredLevels;
1023+
}
1024+
1025+
const stringvec & Column::nonFilteredLevels()
10211026
{
10221027
if (_nonFilteredLevels.empty())
10231028
{
@@ -1852,7 +1857,7 @@ void Column::valuesReverse()
18521857
}
18531858
}
18541859

1855-
upgradeExtractDoublesIntsFromLabels(); //Make sure _dbls reflect _ints
1860+
18561861
dbUpdateValues();
18571862

18581863
labelsHandleAutoSort(false);

CommonData/column.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,8 @@ class Column : public DataSetBaseNode
156156

157157
int nonFilteredNumericsCount();
158158
int nonFilteredNumericsCount() const;
159-
stringvec nonFilteredLevels();
159+
const stringvec & nonFilteredLevels();
160+
const stringvec & nonFilteredLevels() const;
160161
void nonFilteredCountersReset(bool updateLabelIndexes = true);
161162

162163
std::set<qsizetype> labelsMoveRows(std::vector<qsizetype> rows, bool up);

CommonData/dataset.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ Column *DataSet::column(const QString &name)
244244
return column(fq(name));
245245
}
246246

247-
Column *DataSet::column(size_t index)
247+
Column *DataSet::column(int index)
248248
{
249249
if(index < 0 || index >= _columns.size())
250250
return nullptr;

CommonData/dataset.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,9 @@ class DataSet : public DataSetBaseNode
4040
EmptyValues * emptyValues() { return _emptyValues; }
4141

4242
Column * column( const std::string & name);
43+
Column * column( const char * name) { return column(std::string(name));}
4344
Column * column( const QString & name);
44-
Column * column( size_t columnIndex);
45+
Column * column( int columnIndex);
4546

4647
Column * operator[]( size_t columnIndex) { return column(columnIndex); }
4748
Column * operator[]( const std::string & columnName) { return column(columnName); }

Tests/TestLibrary/csv/Data Import Test CSV.json

Lines changed: 1196 additions & 1 deletion
Large diffs are not rendered by default.

Tests/testdebugdata.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1+
#include "qutils.h"
12
#include "testinfo.h"
23
#include "tempfiles.h"
34
#include "processinfo.h"
45
#include "testdebugdata.h"
5-
#include "utilities/qutils.h"
66
#include "databaseinterface.h"
77
#include "data/datasetpackage.h"
88
#include "data/importers/csvimporter.h"

0 commit comments

Comments
 (0)