fix: only mark non-rotational HDDs as SSD

dudyas6 · dudyas6 · commit 066e436ece17 · 2025-08-14T14:35:12.000+03:00
Fixes sr0 incorrectly showing as SSD on RHCOS 4.19.

Signed-off-by: David Asulin &lt;dasulin@redhat.com&gt;
diff --git a/pkg/block/block_linux.go b/pkg/block/block_linux.go
@@ -331,7 +331,7 @@ func disks(ctx *context.Context, paths *linuxpath.Paths) []*Disk {
 		driveType, storageController := diskTypes(dname)
 		// TODO(jaypipes): Move this into diskTypes() once abstracting
 		// diskIsRotational for ease of unit testing
-		if !diskIsRotational(ctx, paths, dname) {
+		if !diskIsRotational(ctx, paths, dname) && driveType == DRIVE_TYPE_HDD {
 			driveType = DRIVE_TYPE_SSD
 		}
 		size := diskSizeBytes(paths, dname)

Original file line number	Diff line number	Diff line change
`@@ -331,7 +331,7 @@ func disks(ctx context.Context, paths linuxpath.Paths) []*Disk {`
`331`	`331`	`driveType, storageController := diskTypes(dname)`
`332`	`332`	`// TODO(jaypipes): Move this into diskTypes() once abstracting`
`333`	`333`	`// diskIsRotational for ease of unit testing`
`334`		`- if !diskIsRotational(ctx, paths, dname) {`
	`334`	`+ if !diskIsRotational(ctx, paths, dname) && driveType == DRIVE_TYPE_HDD {`
`335`	`335`	`driveType = DRIVE_TYPE_SSD`
`336`	`336`	`}`
`337`	`337`	`size := diskSizeBytes(paths, dname)`