changed table strings to use 4 bytes instead of 2 by default

Author: Jack Dermody

.gitignore

@@ -70,3 +70,4 @@
 /BrightData.DataFrame/obj
 /BrightData.DataFrame/bin
 .aider*
+/.idea/.idea.BrightWire/.idea

BrightData/Analysis/CastToDoubleNumericAnalysis.cs

@@ -16,9 +16,9 @@ internal class ConvertToDoubleNumericAnalysis<T>(uint writeCount = Consts.MaxWri
 
         public NumericAnalyser<double> Analysis { get; } = new(writeCount);
 
-        public void Add(T val)
+        public void Add(T obj)
         {
-            Analysis.Add(_converter.Convert(val));
+            Analysis.Add(_converter.Convert(obj));
         }
 
         public void AddObject(object obj)

BrightData/Analysis/DimensionAnalyser.cs

@@ -19,14 +19,8 @@ internal class DimensionAnalyser : IDataAnalyser<IReadOnlyTensor<float>>
         public void Add(IReadOnlyTensor<float> obj)
         {
             uint x = 0, y = 0, z = 0, c = 0;
-            if (obj is IHaveTensor4DDimensions tensor4D) {
-                if (TensorCount == null || tensor4D.Count > TensorCount)
-                    TensorCount = c = tensor4D.ColumnCount;
-            }
-            if (obj is IHaveTensor3DDimensions tensor3D) {
-                if (ZDimension == null || tensor3D.Depth > ZDimension)
-                    ZDimension = z = tensor3D.Depth;
-            }
+            if (obj is IHaveTensor4DDimensions tensor4D && (TensorCount == null || tensor4D.Count > TensorCount)) TensorCount = c = tensor4D.ColumnCount;
+            if (obj is IHaveTensor3DDimensions tensor3D && (ZDimension == null || tensor3D.Depth > ZDimension)) ZDimension = z = tensor3D.Depth;
             if (obj is IHaveMatrixDimensions matrix) {
                 if (XDimension == null || matrix.ColumnCount > XDimension)
                     XDimension = x = matrix.ColumnCount;

BrightData/Analysis/NormalisationModel.cs

@@ -43,7 +43,7 @@ public NormalisationModel(NormalizationType type, MetaData analysedMetaData)
                     throw new NotImplementedException();
             }
             else
-                throw new Exception("Metadata did not indicate numeric data that has been analyzed");
+                throw new InvalidOperationException("Metadata did not indicate numeric data that has been analyzed");
 
             Divide = divide;
             Subtract = subtract;

BrightData/Analysis/NumericAnalyser.cs

@@ -17,30 +17,30 @@ internal class NumericAnalyser<T>(uint writeCount = Consts.MaxWriteCount) : Onli
 		T _mode, _l2;
 		ulong _highestCount;
 
-        public override void Add(T val)
+        public override void Add(T value)
 		{
-			base.Add(val);
+			base.Add(value);
 
 			// find the min and the max
-			if (val < Min)
-				Min = val;
-			if (val > Max)
-				Max = val;
+			if (value < Min)
+				Min = value;
+			if (value > Max)
+				Max = value;
 
 			// add to distinct values
-            if (_distinct.TryGetValue(val, out var count))
-                _distinct[val] = ++count;
+            if (_distinct.TryGetValue(value, out var count))
+                _distinct[value] = ++count;
             else
-                _distinct.Add(val, count = 1);
+                _distinct.Add(value, count = 1);
 
             if (count > _highestCount) {
                 _highestCount = count;
-                _mode = val;
+                _mode = value;
             }
 
 			// calculate norms
-			L1Norm += T.Abs(val);
-			_l2 += val * val;
+			L1Norm += T.Abs(value);
+			_l2 += value * value;
 		}
 
         public void Append(ReadOnlySpan<T> span)

BrightData/BrightData.csproj

@@ -49,6 +49,9 @@
 
 	<ItemGroup>
     <PackageReference Include="CommunityToolkit.HighPerformance" Version="8.4.0" />
+    <PackageReference Include="DotNext" Version="5.26.0" />
+    <PackageReference Include="DotNext.IO" Version="5.26.0" />
+    <PackageReference Include="DotNext.Unsafe" Version="5.26.0" />
     <PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="6.1.2" />
   </ItemGroup>