-
-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershacktoberfestIssue that is created for the Hacktoberfest eventIssue that is created for the Hacktoberfest event
Description
Issues
- Log messages are currently lacking some information, e.g.,
Line 171 in 11da7a9
trace!("This page does not contain any annotations, inserting an empty array");
does not indicate the page id, which makes it harder to debug; - All messages (log and error) should end with a ".";
- The following
Lines 205 to 216 in 11da7a9
let mut msg = String::from("Processing documents: "); self.files .iter() .enumerate() .for_each(|(document_number, file)| { msg.push_str(&format!("{file:?} (#{document_number})")); if document_number < self.files.len() - 1 { msg.push_str(", "); } }); info!("{msg}");
should probably useslice::join.
How to fix
Fixes are pretty easy, feel free to submit a pull request!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershacktoberfestIssue that is created for the Hacktoberfest eventIssue that is created for the Hacktoberfest event