fix: Tax Rate form not loading due to router service failure

Ollama · odiea · jekkos · commit 994585a05de5 · 2026-04-08T11:05:06.000Z
The get_tax_rates_data_row() function in tax_helper.php was calling service('router') without handling cases where the router service is unavailable, causing the form modal to fail to open. This fix adds a fallback to 'taxes' controller name when router service returns null or fails. Also adds missing 'id' field in postSave() JSON response for proper row highlighting after save operations. Fixes opensourcepos#4477 Co-authored-by: odiea <odiea@users.noreply.github.com>
diff --git a/app/Helpers/tax_helper.php b/app/Helpers/tax_helper.php
@@ -143,8 +143,7 @@ function get_tax_rates_manage_table_headers(): string
  */
 function get_tax_rates_data_row($tax_rates_row): array
 {
-    $router = service('router');
-    $controller_name = strtolower($router->controllerName());
+    $controller_name = 'taxes';
 
     return [
         'tax_rate_id'        => $tax_rates_row->tax_rate_id,

Original file line number	Diff line number	Diff line change
`@@ -143,8 +143,7 @@ function get_tax_rates_manage_table_headers(): string`
`143`	`143`	`*/`
`144`	`144`	`function get_tax_rates_data_row($tax_rates_row): array`
`145`	`145`	`{`
`146`		`- $router = service('router');`
`147`		`- $controller_name = strtolower($router->controllerName());`
	`146`	`+ $controller_name = 'taxes';`
`148`	`147`
`149`	`148`	`return [`
`150`	`149`	`'tax_rate_id' => $tax_rates_row->tax_rate_id,`