Skip to content

Commit 5b43e2a

Browse files
authored
Merge pull request #92 from alexandre433/master
Fixes issue on Validation check And Updates Facades usage
2 parents 7bd073a + 55f31fe commit 5b43e2a

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

src/App/Http/Traits/ActivityLogger.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,12 @@
22

33
namespace jeremykenedy\LaravelLogger\App\Http\Traits;
44

5+
use Illuminate\Support\Facades\Auth;
56
use Illuminate\Support\Facades\Log;
67
use Illuminate\Support\Facades\Request;
8+
use Illuminate\Support\Facades\Validator;
79
use Jaybizzle\LaravelCrawlerDetect\Facades\LaravelCrawlerDetect as Crawler;
810
use jeremykenedy\LaravelLogger\App\Models\Activity;
9-
use Validator;
1011

1112
trait ActivityLogger
1213
{
@@ -22,7 +23,7 @@ public static function activity($description = null)
2223
$userType = trans('LaravelLogger::laravel-logger.userTypes.guest');
2324
$userId = null;
2425

25-
if (\Auth::check()) {
26+
if (Auth::check()) {
2627
$userType = trans('LaravelLogger::laravel-logger.userTypes.registered');
2728
$userIdField = config('LaravelLogger.defaultUserIDField');
2829
$userId = Request::user()->{$userIdField};
@@ -72,7 +73,7 @@ public static function activity($description = null)
7273
];
7374

7475
// Validation Instance
75-
$validator = Validator::make($data, Activity::Rules([]));
76+
$validator = Validator::make($data, Activity::rules());
7677
if ($validator->fails()) {
7778
$errors = self::prepareErrorMessage($validator->errors(), $data);
7879
if (config('LaravelLogger.logDBActivityLogFailuresToFile')) {

src/App/Models/Activity.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,12 +125,18 @@ public function user()
125125
*/
126126
public static function rules($merge = [])
127127
{
128+
if (\Illuminate\Foundation\Application::VERSION < 5.8) {
129+
$route_url_check = 'active_url';
130+
} else {
131+
$route_url_check = 'url';
132+
}
133+
128134
return array_merge(
129135
[
130136
'description' => 'required|string',
131137
'userType' => 'required|string',
132138
'userId' => 'nullable|integer',
133-
'route' => 'nullable|url',
139+
'route' => 'nullable|'.$route_url_check,
134140
'ipAddress' => 'nullable|ip',
135141
'userAgent' => 'nullable|string',
136142
'locale' => 'nullable|string',

src/LaravelLoggerServiceProvider.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
namespace jeremykenedy\LaravelLogger;
44

55
use Illuminate\Routing\Router;
6+
use Illuminate\Support\Facades\Event;
67
use Illuminate\Support\ServiceProvider;
78
use jeremykenedy\LaravelLogger\App\Http\Middleware\LogActivity;
89

@@ -109,7 +110,7 @@ private function registerEventListeners()
109110
$listeners = $this->getListeners();
110111
foreach ($listeners as $listenerKey => $listenerValues) {
111112
foreach ($listenerValues as $listenerValue) {
112-
\Event::listen(
113+
Event::listen(
113114
$listenerKey,
114115
$listenerValue
115116
);

0 commit comments

Comments
 (0)