Skip to content

Commit e353568

Browse files
authored
Merge pull request #101 from enkia/add-chromeos
Add chromeos
2 parents 88be767 + f1cf29c commit e353568

File tree

4 files changed

+18
-6
lines changed

4 files changed

+18
-6
lines changed

src/App/Http/Controllers/LaravelLoggerController.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ private function mapAdditionalDetails($collectionItems)
5151
$collectionItems->map(function ($collectionItem) {
5252
$eventTime = Carbon::parse($collectionItem->updated_at);
5353
$collectionItem['timePassed'] = $eventTime->diffForHumans();
54-
$collectionItem['userAgentDetails'] = UserAgentDetails::details($collectionItem->useragent);
54+
$collectionItem['userAgentDetails'] = UserAgentDetails::details($collectionItem->userAgent);
5555
$collectionItem['langDetails'] = UserAgentDetails::localeLang($collectionItem->locale);
5656
$collectionItem['userDetails'] = config('LaravelLogger.defaultUserModel')::find($collectionItem->userId);
5757

@@ -111,7 +111,7 @@ public function showAccessLogEntry(Request $request, $id)
111111
$activity = Activity::findOrFail($id);
112112

113113
$userDetails = config('LaravelLogger.defaultUserModel')::find($activity->userId);
114-
$userAgentDetails = UserAgentDetails::details($activity->useragent);
114+
$userAgentDetails = UserAgentDetails::details($activity->userAgent);
115115
$ipAddressDetails = IpAddressDetails::checkIP($activity->ipAddress);
116116
$langDetails = UserAgentDetails::localeLang($activity->locale);
117117
$eventTime = Carbon::parse($activity->created_at);
@@ -205,7 +205,7 @@ public function showClearedAccessLogEntry(Request $request, $id)
205205
$activity = self::getClearedActvity($id);
206206

207207
$userDetails = config('LaravelLogger.defaultUserModel')::find($activity->userId);
208-
$userAgentDetails = UserAgentDetails::details($activity->useragent);
208+
$userAgentDetails = UserAgentDetails::details($activity->userAgent);
209209
$ipAddressDetails = IpAddressDetails::checkIP($activity->ipAddress);
210210
$langDetails = UserAgentDetails::localeLang($activity->locale);
211211
$eventTime = Carbon::parse($activity->created_at);

src/App/Http/Traits/UserAgentDetails.php

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public static function details($ua)
1515
{
1616
$ua = is_null($ua) ? $_SERVER['HTTP_USER_AGENT'] : $ua;
1717
// Enumerate all common platforms, this is usually placed in braces (order is important! First come first serve..)
18-
$platforms = 'Windows|iPad|iPhone|Macintosh|Android|BlackBerry|Unix|Linux';
18+
$platforms = 'Windows|iPad|iPhone|Macintosh|Android|BlackBerry|Unix|Linux|X11|CrOS';
1919

2020
// All browsers except MSIE/Trident and..
2121
// NOT for browsers that use this syntax: Version/0.xx Browsername
@@ -53,7 +53,11 @@ public static function details($ua)
5353
$return['version'] = $ua_array[4];
5454
}
5555
} else {
56-
return false;
56+
$return['platform'] = '-';
57+
$return['type'] = '-';
58+
$return['renderer'] = '-';
59+
$return['browser'] = '-';
60+
$return['version'] = '-';
5761
}
5862

5963
// Replace some browsernames e.g. MSIE -> Internet Explorer
@@ -98,7 +102,7 @@ public static function localeLang($locale)
98102
}
99103

100104
$a = explode(',', $locale);
101-
$a = explode(';', $a[1]);
105+
$a ??= explode(';', $a[1]);
102106

103107
return $a[0];
104108
}

src/resources/views/logger/activity-log-item.blade.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,10 @@
123123
$platformIcon = 'fa-linux';
124124
break;
125125
126+
case 'CrOS':
127+
$platformIcon = 'fa-chrome';
128+
break;
129+
126130
default:
127131
$platformIcon = 'fa-';
128132
break;

src/resources/views/logger/partials/activity-table.blade.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,10 @@
185185
$platformIcon = 'fa-linux';
186186
break;
187187
188+
case 'CrOS':
189+
$platformIcon = 'fa-chrome';
190+
break;
191+
188192
default:
189193
$platformIcon = 'fa-';
190194
break;

0 commit comments

Comments
 (0)